Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace write! with to_css and write_str in some ToCss impls #18159
Conversation
highfive
commented
Aug 20, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 20, 2017
|
|
|
r? @SimonSapin |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 21, 2017
Replace write! with to_css and write_str in some ToCss impls Some of this is necessary for fixing things like [bug 1370779](https://bugzilla.mozilla.org/show_bug.cgi?id=1370779) because otherwise we would still not be using the new numeric serialization algorithm from cssparser crate. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18159) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 21, 2017
Add whitespace before line number in grid line This is a followup fix of #18159 where the space was incorrectly removed. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18169) <!-- Reviewable:end -->
SimonSapin
added a commit
that referenced
this pull request
Aug 23, 2017
Pull in servo/rust-cssparser#173, which together with #18159 fixes #17205
bors-servo
added a commit
that referenced
this pull request
Aug 23, 2017
Update cssparser to 0.19.2 Pull in servo/rust-cssparser#173, which together with #18159 fixes #17205.
bors-servo
added a commit
that referenced
this pull request
Aug 23, 2017
Update cssparser to 0.19.2 Pull in servo/rust-cssparser#173, which together with #18159 fixes #17205. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18201) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Aug 23, 2017
Update cssparser to 0.19.2 Pull in servo/rust-cssparser#173, which together with #18159 fixes #17205. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18201) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
upsuper commentedAug 20, 2017
•
edited by SimonSapin
Some of this is necessary for fixing things like bug 1370779 because otherwise we would still not be using the new numeric serialization algorithm from cssparser crate.
This change is