Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cssparser to 0.19.2 #18201

Merged
merged 1 commit into from Aug 23, 2017
Merged

Update cssparser to 0.19.2 #18201

merged 1 commit into from Aug 23, 2017
+23 −13

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Aug 23, 2017 •
edited by metajack

Pull in servo/rust-cssparser#173, which together with #18159 fixes #17205.

This change is Reviewable
@SimonSapin
Update cssparser to 0.19.2
Loading status checks…
4d10edf 
Pull in servo/rust-cssparser#173,
which together with #18159 fixes #17205
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 23, 2017

@bors-servo try

This will likely require test expectation changes.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2017

⌛ Trying commit 4d10edf with merge 659041b...
bors-servo added a commit that referenced this pull request Aug 23, 2017
@bors-servo
Auto merge of #18201 - servo:cssparserup, r=<try>
Loading status checks…
659041b 
Update cssparser to 0.19.2

Pull in servo/rust-cssparser#173, which together with #18159 fixes #17205.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2017

💔 Test failed - mac-rel-wpt3
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 23, 2017 •
edited 

exceptions.Exception: Actual commit (43d3376e5d70cab93405d8ba7753beedad8c8370) differs from requested commit (659041b3fa81371d0a515f9b9ac7f370ec713a11)

¯\_(ツ)_/¯

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2017

⌛ Trying commit 4d10edf with merge 995c5b3b89dbfa5116e7c6f5dcab634f91ccba42...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2017

⌛ Trying commit 4d10edf with merge 2bb1427...
bors-servo added a commit that referenced this pull request Aug 23, 2017
@bors-servo
Auto merge of #18201 - servo:cssparserup, r=<try>
Loading status checks…
2bb1427 
Update cssparser to 0.19.2

Pull in servo/rust-cssparser#173, which together with #18159 fixes #17205.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18201)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2017

💔 Test failed - mac-rel-wpt3
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 23, 2017

@upsuper r?

Aside from buildbot sometimes picking up the wrong commit, try is green. Maybe we’re missing some tests that Gecko has around serialization.
@upsuper
Copy link
Member

upsuper commented Aug 23, 2017

Oh, IIRC all annotations I fixed for wpt are for shape-outside, which seems to be gecko-only at the moment, so yeah, probably there wouldn't be any unexpected pass for servo.
@upsuper
Copy link
Member

upsuper commented Aug 23, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2017

📌 Commit 4d10edf has been approved by upsuper
@highfive highfive assigned upsuper and unassigned nox Aug 23, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2017

⌛ Testing commit 4d10edf with merge 2e775ab...
bors-servo added a commit that referenced this pull request Aug 23, 2017
@bors-servo
Auto merge of #18201 - servo:cssparserup, r=upsuper
Loading status checks…
2e775ab 
Update cssparser to 0.19.2

Pull in servo/rust-cssparser#173, which together with #18159 fixes #17205.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18201)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: upsuper
Pushing 2e775ab to master...
@bors-servo bors-servo merged commit 4d10edf into master Aug 23, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 23, 2017
Merged
@SimonSapin SimonSapin deleted the cssparserup branch Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@upsuper upsuper

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

float to string conversions have rounding errors due to trying to produce too many digits
5 participants
@SimonSapin @bors-servo @upsuper @nox @highfive
You can’t perform that action at this time.