Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FnvHashMap in WebGL implementation. #18221

Merged
merged 1 commit into from Aug 24, 2017
Merged

Use FnvHashMap in WebGL implementation. #18221

merged 1 commit into from Aug 24, 2017

Conversation

@MortimerGoro
Copy link
Contributor

MortimerGoro commented Aug 24, 2017 •
edited by SimonSapin

Follow up from the WebGL redesign: #17891

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@MortimerGoro
Use FnvHashMap in WebGL implementation.
Loading status checks…
0a64455
@highfive
Copy link

highfive commented Aug 24, 2017

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webglrenderingcontext.rs, components/script/dom/webgl_extensions/extensions.rs
  • @fitzgen: components/script/dom/webglrenderingcontext.rs, components/script/dom/webgl_extensions/extensions.rs
  • @emilio: components/script/dom/webglrenderingcontext.rs, components/script/dom/webgl_extensions/extensions.rs, components/canvas/webgl_thread.rs
@highfive
Copy link

highfive commented Aug 24, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Aug 24, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2017

📌 Commit 0a64455 has been approved by jdm
@highfive highfive assigned jdm and unassigned KiChjang Aug 24, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2017

⌛ Testing commit 0a64455 with merge 4598ddb...
bors-servo added a commit that referenced this pull request Aug 24, 2017
@bors-servo
Auto merge of #18221 - MortimerGoro:webgl_fnv, r=jdm
Loading status checks…
4598ddb 
Use FnvHashMap in WebGL implementation.

<!-- Please describe your changes on the following line: -->

Follow up from the WebGL redesign: #17891

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18221)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 4598ddb to master...
@bors-servo bors-servo merged commit 0a64455 into servo:master Aug 24, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@MortimerGoro @highfive @jdm @bors-servo @KiChjang
You can’t perform that action at this time.