Implement Ellipse Canvas 2D API

[joone]

This patch needs to update rust-azure to 0.21.0.

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #17598

• [] There are tests for these changes OR
• [] These changes do not require tests because _____

---

This change is 

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon.

[highfive]

Heads up! This PR modifies the following files:

• @fitzgen: components/script/dom/paintrenderingcontext2d.rs, components/script/dom/canvasrenderingcontext2d.rs, components/script/dom/webidls/CanvasRenderingContext2D.webidl
• @KiChjang: components/script/dom/paintrenderingcontext2d.rs, components/script/dom/canvasrenderingcontext2d.rs, components/script/dom/webidls/CanvasRenderingContext2D.webidl

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[joone]

Is it okay to add a test case: tests/wpt/web-platform-tests/offscreen-canvas/path-objects/2d.path.ellipse.html?

[stshine]

@bors-servo try

[bors-servo]

⌛ Trying commit 64c727b with merge 9a1019d...

[bors-servo]

💔 Test failed - windows-msvc-dev

[stshine]

"C:\buildbot\slave\windows-msvc-dev\build\target\debug\build\azure-3f01c03fa9e237b5\out\build\install.vcxproj" (default target) (1) ->
"C:\buildbot\slave\windows-msvc-dev\build\target\debug\build\azure-3f01c03fa9e237b5\out\build\ALL_BUILD.vcxproj" (default target) (3) ->
"C:\buildbot\slave\windows-msvc-dev\build\target\debug\build\azure-3f01c03fa9e237b5\out\build\azure.vcxproj" (default target) (4) ->
(ClCompile target) -> 
  C:\Users\Administrator\.cargo\git\checkouts\rust-azure-984e17605d95e219\a2351f2\libazure\DrawTargetD2D.cpp(1294): error C2259: 'mozilla::gfx::PathBuilderD2D': cannot instantiate abstract class [C:\buildbot\slave\windows-msvc-dev\build\target\debug\build\azure-3f01c03fa9e237b5\out\build\azure.vcxproj]
  C:\Users\Administrator\.cargo\git\checkouts\rust-azure-984e17605d95e219\a2351f2\libazure\PathD2D.cpp(348): error C2259: 'mozilla::gfx::PathBuilderD2D': cannot instantiate abstract class [C:\buildbot\slave\windows-msvc-dev\build\target\debug\build\azure-3f01c03fa9e237b5\out\build\azure.vcxproj]

[joone]

I'm fixing the build break: servo/rust-azure#273

[joone]

@stshine My fix landed in rust-azure. Can you run build bots again?

[jdm]

@bors-servo try

[bors-servo]

⌛ Trying commit 7ea84ff with merge bdab299...

[jdm]

This doesn't look good:

C:\projects\servo\.cargo\git\checkouts\rust-azure-984e17605d95e219\a2351f2\libazure\DrawTargetD2D.cpp(1294): error C2259: 'mozilla::gfx::PathBuilderD2D': cannot instantiate abstract class [C:\projects\servo\target\debug\build\azure-3f01c03fa9e237b5\out\build\azure.vcxproj]
  C:\projects\servo\.cargo\git\checkouts\rust-azure-984e17605d95e219\a2351f2\libazure\DrawTargetD2D.cpp(1294): note: due to following members:
  C:\projects\servo\.cargo\git\checkouts\rust-azure-984e17605d95e219\a2351f2\libazure\DrawTargetD2D.cpp(1294): note: 'void mozilla::gfx::PathSink::Arc(const mozilla::gfx::Point &,float,float,float,float,float,bool)': is abstract
  c:\projects\servo\.cargo\git\checkouts\rust-azure-984e17605d95e219\a2351f2\libazure\2D.h(451): note: see declaration of 'mozilla::gfx::PathSink::Arc'

[bors-servo]

💔 Test failed - windows-msvc-dev

[joone]

servo/rust-azure#274

[joone]

@jdm Can you run build bots?

[jdm]

I think you need to run ./mach cargo-update -p azure and push the changes before they will show up.

[joone]

@jdm Done, Thanks!

[stshine]

@bors-servo try

[bors-servo]

⌛ Trying commit dc4b6d0 with merge 5bb142d...

[jdm]

@bors-servo r+
Thanks!

[bors-servo]

📌 Commit fd09294 has been approved by jdm

[bors-servo]

⌛ Testing commit fd09294 with merge d4b20df...

[bors-servo]

💔 Test failed - linux-rel-wpt

[joone]

@jdm Here is a log from linux-rel-wpt:
{"status": "FAIL", "group": "default", "message": "/_mozilla/mozilla/css-paint-api/background-image-tiled.html ebc42c91261f94d0907b46e396e609ba822678cb\n/_mozilla/mozilla/css-paint-api/background-image-tiled-ref.html 35ba3945e6b317536fde7758020490913812c005\nTesting ebc42c91261f94d0907b46e396e609ba822678cb == 35ba3945e6b317536fde7758020490913812c005", "stack": null, "subtest": null, "test": "/_mozilla/mozilla/css-paint-api/background-image-tiled.html", "line": 93729, "action": "test_result", "expected": "PASS"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "ellipse" with the proper type (78)", "test": "/html/dom/interfaces.html", "line": 221873, "action": "test_result", "expected": "FAIL"}

Hmm, I fixed this problem by adding the ini file.

[jdm]

https://github.com/joone/servo/blob/fd09294f30460cbb3270a12e9b2ceb1b3dd0b80a/tests/wpt/metadata/html/dom/interfaces.html.ini#L9585-L9586

Oops, the new ini belongs in https://github.com/joone/servo/tree/fd09294f30460cbb3270a12e9b2ceb1b3dd0b80a/tests/wpt/mozilla/meta/mozilla/css-paint-api instead.

[joone]

@jdm Do you mean that we don't need the new ini file and we have to remove the following line from interface.ini file?
[CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "ellipse" with the proper type (78)]
expected: FAIL

[jdm]

We still need the new ini file, but I gave you the wrong directory previously. And yes, we need to remove the lines that I linked from interfaces.html.ini.

[joone]

@jdm can you take a look at the error?

[jdm]

@bors-servo: r+
The travisCI error is #18346.

[bors-servo]

📌 Commit 57e283a has been approved by jdm

[bors-servo]

⌛ Testing commit 57e283a with merge 3a4b98a...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 3a4b98a to master...

[joone]

@jdm Thanks for the review!