Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPrioritize parsing non-custom property names. #18279
Merged
Conversation
highfive
commented
Aug 28, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 28, 2017
|
|
|
@bors-servo r+ Thanks! |
|
|
|
@bors-servo: p=1 |
bors-servo
added a commit
that referenced
this pull request
Aug 28, 2017
Prioritize parsing non-custom property names. This should cause a slight improvement in the common case where we are parsing non-custom property names. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18279) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Aug 28, 2017
Prioritize parsing non-custom property names. This should cause a slight improvement in the common case where we are parsing non-custom property names. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18279) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedAug 28, 2017
•
edited by larsbergstrom
This should cause a slight improvement in the common case where we are parsing non-custom property names.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is