User Timing API #18283

ferjm · 2017-08-28T19:45:12Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #18109
There are tests for these changes. I enabled the peformance-timeline API WPTs but some of them are still failing because of implementation bugs or missing APIs (Resource Timing, for instance) the tests are dependent of. I'll file issues to fix them.

This change is

highfive · 2017-08-28T19:45:15Z

Heads up! This PR modifies the following files:

@jgraham: tests/wpt/include.ini
@fitzgen: components/script/dom/performance.rs, components/script/dom/webidls/PerformanceMark.webidl, components/script/dom/macros.rs, components/script/dom/performanceobserver.rs, components/script/dom/performancemark.rs and 4 more
@KiChjang: components/script/dom/performance.rs, components/script/dom/webidls/PerformanceMark.webidl, components/script/dom/macros.rs, components/script/dom/performanceobserver.rs, components/script/dom/performancemark.rs and 4 more

ferjm · 2017-08-28T19:46:40Z

r? @jdm

jdm · 2017-08-28T21:22:06Z

@bors-servo: r+
Thanks!

bors-servo · 2017-08-28T21:22:06Z

📌 Commit 8cbd47e has been approved by jdm

bors-servo · 2017-08-29T05:23:57Z

⌛ Testing commit 8cbd47e with merge a91250e...


        Auto merge of #18283 - ferjm:user.timing.api, r=jdm

User Timing API - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18109 - [X] There are tests for these changes. I enabled the peformance-timeline API WPTs but some of them are still failing because of implementation bugs or missing APIs (Resource Timing, for instance) the tests are dependent of. I'll file issues to fix them.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18283)

bors-servo · 2017-08-29T05:58:35Z

💔 Test failed - linux-rel-wpt

ferjm · 2017-08-29T07:52:09Z

@bors-servo: try

bors-servo · 2017-08-29T07:52:14Z

⌛ Trying commit 221aef9 with merge 845a6ea...


        Auto merge of #18283 - ferjm:user.timing.api, r=<try>

User Timing API - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18109 - [X] There are tests for these changes. I enabled the peformance-timeline API WPTs but some of them are still failing because of implementation bugs or missing APIs (Resource Timing, for instance) the tests are dependent of. I'll file issues to fix them.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18283)

bors-servo · 2017-08-29T08:56:02Z

💔 Test failed - linux-rel-wpt

ferjm · 2017-08-29T18:10:59Z

I'll try to fix #18286 before merging this one.

bors-servo · 2017-09-01T02:23:51Z

☔ The latest upstream changes (presumably #18317) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo · 2017-09-04T10:37:59Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

jdm · 2017-09-05T17:24:43Z

components/script/dom/performance.rs

+                          .rev()
+                          .position(|e| *e.entry_type() == *entry_type &&
+                                        *e.name() == *name) {
+            Some(pos) => self.entries[pos].start_time(),


If we use find instead of position, we can access the entry directly instead of using an index.

jdm · 2017-09-05T17:24:43Z

components/script/dom/performance.rs

+        let global = self.global();
+        // Step 1.
+        if global.is::<Window>() && INVALID_ENTRY_NAMES.contains(&mark_name.as_ref()) {
+            return Err((Error::Syntax));


Nit: remove the extra ()s.

jdm · 2017-09-05T17:24:43Z

components/script/dom/webidls/Performance.webidl

@@ -28,3 +28,14 @@ partial interface Performance {
  PerformanceEntryList getEntriesByName(DOMString name,
                                        optional DOMString type);
 };
+
+// http://www.w3.org/TR/user-timing/


https://w3c.github.io/user-timing/#extensions-performance-interface


        User Timing API

ferjm · 2017-09-07T16:31:00Z

r? @jdm

jdm · 2017-09-07T17:11:00Z

@bors-servo: r+

bors-servo · 2017-09-07T17:11:00Z

📌 Commit 8412f54 has been approved by jdm

bors-servo · 2017-09-07T17:45:48Z

⌛ Testing commit 8412f54 with merge 1e93749...


        Auto merge of #18283 - ferjm:user.timing.api, r=jdm

User Timing API - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18109 - [X] There are tests for these changes. I enabled the peformance-timeline API WPTs but some of them are still failing because of implementation bugs or missing APIs (Resource Timing, for instance) the tests are dependent of. I'll file issues to fix them.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18283)

bors-servo · 2017-09-07T18:52:44Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 1e93749 to master...


        Auto merge of servo#18283 - ferjm:user.timing.api, r=jdm

User Timing API - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix servo#18109 - [X] There are tests for these changes. I enabled the peformance-timeline API WPTs but some of them are still failing because of implementation bugs or missing APIs (Resource Timing, for instance) the tests are dependent of. I'll file issues to fix them.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18283)  Make Performance Timeline API work in Workers


        Auto merge of #18370 - pylbrecht:observer, r=ferjm

@ferjm

An observer disconnected after a mark must receive the mark  I worked on top of #18283 as suggested [here](#18284 (comment)). r? @ferjm  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18284 (github issue number if applicable).  - [X] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18370)


        Auto merge of #18372 - tigercosmos:userTimingApi, r=<try>

@ferjm

TEST: fix and add case of po-observe.any.js  1. implementing step 3 from the [`PerformanceObserver.observe()`](https://w3c.github.io/performance-timeline/#dom-performanceobserver-observe()) method spec properly. 2. also add cases about step 1 & 2 work on the top of #18283 r? @ferjm ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18285 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18372)


        Auto merge of #18372 - tigercosmos:userTimingApi, r=ferjm

@ferjm

TEST: fix and add case of po-observe.any.js  1. implementing step 3 from the [`PerformanceObserver.observe()`](https://w3c.github.io/performance-timeline/#dom-performanceobserver-observe()) method spec properly. 2. also add cases about step 1 & 2 work on the top of #18283 r? @ferjm ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18285 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18372)

highfive assigned mbrubeck Aug 28, 2017

highfive added the S-awaiting-review label Aug 28, 2017

highfive assigned jdm and unassigned mbrubeck Aug 28, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Aug 28, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Aug 29, 2017

ferjm force-pushed the ferjm:user.timing.api branch from 8cbd47e to 221aef9 Aug 29, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Aug 29, 2017

highfive added the S-tests-failed label Aug 29, 2017

ferjm mentioned this pull request Aug 30, 2017

An observer disconnected after a mark must receive the mark #18284

Closed

highfive added the S-needs-rebase label Sep 1, 2017

ferjm mentioned this pull request Sep 1, 2017

Performance observer must replace observer if it's already present #18285

Closed

ferjm force-pushed the ferjm:user.timing.api branch from 221aef9 to 179e556 Sep 2, 2017

highfive removed the S-tests-failed label Sep 2, 2017

ferjm force-pushed the ferjm:user.timing.api branch from 24daea3 to 0e0519b Sep 4, 2017

pylbrecht mentioned this pull request Sep 4, 2017

An observer disconnected after a mark must receive the mark #18370

Merged

4 of 4 tasks complete

ferjm force-pushed the ferjm:user.timing.api branch from 0e0519b to 4ef68bd Sep 4, 2017

tigercosmos mentioned this pull request Sep 4, 2017

TEST: fix and add case of po-observe.any.js #18372

Merged

3 of 5 tasks complete

ferjm force-pushed the ferjm:user.timing.api branch 2 times, most recently from 14b1e2e to 88df5ea Sep 5, 2017

jdm requested changes Sep 5, 2017

View changes

jdm added S-needs-code-changes and removed S-awaiting-review S-needs-rebase labels Sep 5, 2017

User Timing API

Loading status checks…

8412f54

ferjm force-pushed the ferjm:user.timing.api branch from 88df5ea to 8412f54 Sep 6, 2017

highfive added S-awaiting-review and removed S-needs-code-changes labels Sep 6, 2017

highfive removed the S-awaiting-review label Sep 7, 2017

jdm approved these changes Sep 7, 2017

View changes

highfive added the S-awaiting-merge label Sep 7, 2017

bors-servo merged commit 8412f54 into servo:master Sep 7, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Sep 7, 2017

servo / servo

User Timing API #18283

User Timing API #18283

ferjm commented Aug 28, 2017 •

edited by nox

highfive commented Aug 28, 2017

ferjm commented Aug 28, 2017

jdm commented Aug 28, 2017

bors-servo commented Aug 28, 2017

bors-servo commented Aug 29, 2017

bors-servo commented Aug 29, 2017

ferjm commented Aug 29, 2017

bors-servo commented Aug 29, 2017

bors-servo commented Aug 29, 2017

ferjm commented Aug 29, 2017

bors-servo commented Sep 1, 2017

bors-servo commented Sep 4, 2017

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ferjm commented Sep 7, 2017

jdm commented Sep 7, 2017

bors-servo commented Sep 7, 2017

bors-servo commented Sep 7, 2017

bors-servo commented Sep 7, 2017

servo / servo

Join GitHub today

User Timing API #18283

User Timing API #18283

Conversation

ferjm commented Aug 28, 2017 • edited by nox

highfive commented Aug 28, 2017

ferjm commented Aug 28, 2017

jdm commented Aug 28, 2017

bors-servo commented Aug 28, 2017

bors-servo commented Aug 29, 2017

bors-servo commented Aug 29, 2017

ferjm commented Aug 29, 2017

bors-servo commented Aug 29, 2017

bors-servo commented Aug 29, 2017

ferjm commented Aug 29, 2017

bors-servo commented Sep 1, 2017

bors-servo commented Sep 4, 2017

This comment has been minimized.

jdm Sep 5, 2017

This comment has been minimized.

jdm Sep 5, 2017

This comment has been minimized.

jdm Sep 5, 2017

ferjm commented Sep 7, 2017

jdm commented Sep 7, 2017

bors-servo commented Sep 7, 2017

bors-servo commented Sep 7, 2017

bors-servo commented Sep 7, 2017

ferjm commented Aug 28, 2017 •

edited by nox