Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report more specific CSS selector errors #18290

Merged
merged 7 commits into from Aug 29, 2017
Merged

Report more specific CSS selector errors #18290

merged 7 commits into from Aug 29, 2017

Conversation

@jdm
Copy link
Member

jdm commented Aug 29, 2017 •
edited by SimonSapin

Report more specific errors for invalid CSS selectors. Reviewed by @heycam in https://bugzilla.mozilla.org/show_bug.cgi?id=1384216.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
jdm added 7 commits Aug 29, 2017
@jdm
Allow null parameters for Gecko error reporter (bug 1384216).
f94612c
@jdm
Report unknown pseudos (bug 1384216).
8e20a6a
@jdm
Report unexpected attribute selector tokens (bug 1384216).
73e903a
@jdm
Report more specific invalid attribute selectors (bug 1384216).
408c34a
@jdm
Report invalid selectors (bug 1384216).
9a7cceb
@jdm
Report more invalid selectors (bug 1384216).
4016371
@jdm
Report invalid at-rules (bug 1384216).
Loading status checks…
549cdb2
@highfive
Copy link

highfive commented Aug 29, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/selector_parser.rs
  • @canaltinova: components/style/gecko/selector_parser.rs
  • @emilio: components/style/gecko/selector_parser.rs, ports/geckolib/error_reporter.rs
@highfive
Copy link

highfive commented Aug 29, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@jdm jdm changed the title Selectorerr Report more specific CSS selector errors Aug 29, 2017
@jdm
Copy link
Member Author

jdm commented Aug 29, 2017

@bors-servo: r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

📌 Commit 549cdb2 has been approved by heycam
@highfive highfive assigned heycam and unassigned nox Aug 29, 2017
@jdm
Copy link
Member Author

jdm commented Aug 29, 2017

@bors-servo: p=1
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

⌛ Testing commit 549cdb2 with merge 7a826e77b3f6fc2c40abbf0fa5fdeac7b17fbab4...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

💔 Test failed - mac-dev-unit
@jdm
Copy link
Member Author

jdm commented Aug 29, 2017

@bors-servo: retry
bors-servo added a commit that referenced this pull request Aug 29, 2017
@bors-servo
Auto merge of #18290 - jdm:selectorerr, r=heycam
Loading status checks…
b2f8974 
Report more specific CSS selector errors

Report more specific errors for invalid CSS selectors. Reviewed by @heycam in https://bugzilla.mozilla.org/show_bug.cgi?id=1384216.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18290)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

⌛ Testing commit 549cdb2 with merge b2f8974...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing b2f8974 to master...
@bors-servo bors-servo merged commit 549cdb2 into servo:master Aug 29, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @bors-servo @nox @heycam
You can’t perform that action at this time.