Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Remove HasViewportPercentage. #18300

Merged
merged 1 commit into from Aug 30, 2017
Merged

style: Remove HasViewportPercentage. #18300

merged 1 commit into from Aug 30, 2017

Conversation

@emilio
Copy link
Member

emilio commented Aug 29, 2017 •
edited by SimonSapin

It's not needed since #18268, let's kill it.

This change is Reviewable
@emilio
style: Remove HasViewportPercentage.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
36ff89b 
It's not needed since #18268
@highfive
Copy link

highfive commented Aug 29, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/generics/text.rs, components/style/values/computed/percentage.rs, components/style/values/specified/calc.rs, components/style/values/specified/color.rs, components/style/properties/longhand/background.mako.rs and 49 more
  • @canaltinova: components/style/values/generics/text.rs, components/style/values/computed/percentage.rs, components/style/values/specified/calc.rs, components/style/values/specified/color.rs, components/style/properties/longhand/background.mako.rs and 49 more
@nox
Copy link
Member

nox commented Aug 29, 2017

Nice.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

📌 Commit 36ff89b has been approved by nox
@highfive highfive assigned nox and unassigned metajack Aug 29, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

⌛ Testing commit 36ff89b with merge 5b03cab...
bors-servo added a commit that referenced this pull request Aug 29, 2017
@bors-servo
Auto merge of #18300 - emilio:die-hvp-die, r=nox
Loading status checks…
5b03cab 
style: Remove HasViewportPercentage.

It's not needed since #18268, let's kill it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18300)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

💔 Test failed - mac-dev-unit
@emilio
Copy link
Member Author

emilio commented Aug 29, 2017

@bors-servo retry

  • infra
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

⌛ Testing commit 36ff89b with merge c637915...
bors-servo added a commit that referenced this pull request Aug 29, 2017
@bors-servo
Auto merge of #18300 - emilio:die-hvp-die, r=nox
Loading status checks…
c637915 
style: Remove HasViewportPercentage.

It's not needed since #18268, let's kill it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18300)
<!-- Reviewable:end -->
@emilio
Copy link
Member Author

emilio commented Aug 29, 2017

Too bad this diff was that small :(
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

💔 Test failed - linux-rel-wpt
@emilio
Copy link
Member Author

emilio commented Aug 29, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Aug 29, 2017

Any chance this is caused by these changes?

  ▶ ERROR [expected OK] /_mozilla/css/animations/basic-linear-width.html
  └   → uncaught exception: unknown (can't convert to string)

  ▶ Unexpected subtest result in /_mozilla/css/animations/basic-linear-width.html:
  │ TIMEOUT [expected PASS] Animation test: Linear animation repeated infinitely.
  └   → Test timed out
@emilio
Copy link
Member Author

emilio commented Aug 30, 2017

No way, this is removing dead code.

@bors-servo retry
@emilio
Copy link
Member Author

emilio commented Aug 30, 2017

@bors-servo treeclosed- p=1
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

⌛ Testing commit 36ff89b with merge 5dee83d...
bors-servo added a commit that referenced this pull request Aug 30, 2017
@bors-servo
Auto merge of #18300 - emilio:die-hvp-die, r=nox
Loading status checks…
5dee83d 
style: Remove HasViewportPercentage.

It's not needed since #18268, let's kill it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18300)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Aug 30, 2017
Merged
4 of 4 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 5dee83d to master...
@bors-servo bors-servo merged commit 36ff89b into servo:master Aug 30, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:die-hvp-die branch Aug 30, 2017
@bors-servo bors-servo mentioned this pull request Aug 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @nox @bors-servo @jdm @metajack
You can’t perform that action at this time.