Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the WebIDL parser #18309

Merged
merged 1 commit into from Aug 31, 2017
Merged

Update the WebIDL parser #18309

merged 1 commit into from Aug 31, 2017

Conversation

@nox
Copy link
Member

nox commented Aug 30, 2017 •
edited by SimonSapin

This change is Reviewable
@nox
Update the WebIDL parser
Loading status checks…
f16a046
@highfive
Copy link

highfive commented Aug 30, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/codegen/parser/WebIDL.py
  • @KiChjang: components/script/dom/bindings/codegen/parser/WebIDL.py
@highfive
Copy link

highfive commented Aug 30, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Aug 30, 2017

@bors-servi r+
@jdm
Copy link
Member

jdm commented Aug 30, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

📌 Commit f16a046 has been approved by jdm
@highfive highfive assigned jdm and unassigned KiChjang Aug 30, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

⌛ Testing commit f16a046 with merge f734561...
bors-servo added a commit that referenced this pull request Aug 30, 2017
@bors-servo
Auto merge of #18309 - servo:webidl, r=jdm
Loading status checks…
f734561 
Update the WebIDL parser

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18309)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

💔 Test failed - mac-rel-wpt2
@nox
Copy link
Member Author

nox commented Aug 30, 2017

@bors-servo retry #JustInfraThings
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Aug 30, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Aug 30, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Aug 30, 2017

@bors-servo: retry
@jdm
Copy link
Member

jdm commented Aug 30, 2017

@bors-servo: retry
@jdm
Copy link
Member

jdm commented Aug 30, 2017

@bors-servo: force
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Aug 31, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

⌛ Testing commit f16a046 with merge ed9fb55...
bors-servo added a commit that referenced this pull request Aug 31, 2017
@bors-servo
Auto merge of #18309 - servo:webidl, r=jdm
Loading status checks…
ed9fb55 
Update the WebIDL parser

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18309)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing ed9fb55 to master...
@bors-servo bors-servo merged commit f16a046 into master Aug 31, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the webidl branch Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @jdm @bors-servo @KiChjang
You can’t perform that action at this time.