Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake Performance Timeline API work in Workers #18324
Merged
Conversation
highfive
commented
Aug 31, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 31, 2017
|
|
|
r? @jdm |
ferjm
force-pushed the
ferjm:performance.workers
branch
2 times, most recently
from
069a06a
to
3ccd165
|
|
ferjm
force-pushed the
ferjm:performance.workers
branch
4 times, most recently
from
2cc0b54
to
fdcc1ad
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 5, 2017
Make Performance Timeline API work in Workers - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18286 and #18308 This patch makes the Performance Timeline API work in workers, removes the exposure of `Performance.timing` in workers and sets the appropriate value of `Performance.now()` in workers. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18324) <!-- Reviewable:end -->
|
|
This was referenced Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedAug 31, 2017
•
edited by SimonSapin
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis patch makes the Performance Timeline API work in workers, removes the exposure of
Performance.timingin workers and sets the appropriate value ofPerformance.now()in workers.This change is