Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30) #18327

SimonSapin · 2017-08-31T15:30:59Z

Fix this error in the new Rust Nightly:

   Compiling script v0.0.1 (file:///home/simon/servo2/components/script)
error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope
   --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10
    |
464 | #[derive(JSTraceable)]
    |          ^^^^^^^^^^^
    |
    = note: JSTraceable is a function, perhaps you wish to call it
    = help: items from traits can only be used if the trait is implemented and in scope
    = note: the following trait defines an item `trace`, perhaps you need to implement it:
            candidate #1: `dom::bindings::trace::JSTraceable`

error: aborting due to previous error

error: Could not compile `script`.

~~I’ve tried to reproduce it in a minimal test case, but impl<A, B> SomeTrait for fn(A) -> B did not apply for fn(&u32) -> u32 even on Rust 1.19.0 stable. So I don’t know what changed.~~ This is very likely #18327.

This change is


        Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30)

SimonSapin · 2017-08-31T15:37:29Z

@bors-servo r=nox (per IRC discussion)

bors-servo · 2017-08-31T15:37:30Z

📌 Commit 1dcede7 has been approved by nox

bors-servo · 2017-09-01T06:22:24Z

⌛ Testing commit 1dcede7 with merge 8b82f38...


        Auto merge of #18327 - servo:rustup, r=nox

Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30) Fix this error in the new Rust Nightly: ```rust Compiling script v0.0.1 (file:///home/simon/servo2/components/script) error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10 | 464 | #[derive(JSTraceable)] | ^^^^^^^^^^^ | = note: JSTraceable is a function, perhaps you wish to call it = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `trace`, perhaps you need to implement it: candidate #1: `dom::bindings::trace::JSTraceable` error: aborting due to previous error error: Could not compile `script`. ``` ~I’ve tried to reproduce it in a minimal test case, but `impl<A, B> SomeTrait for fn(A) -> B` did not apply for `fn(&u32) -> u32` even on Rust 1.19.0 stable. So I don’t know what changed.~ This is very likely #18327.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18327)

bors-servo · 2017-09-01T06:22:35Z

💔 Test failed - mac-rel-wpt1

SimonSapin · 2017-09-01T06:28:16Z

@bors-servo retry #18338

bors-servo · 2017-09-01T07:39:49Z

⌛ Testing commit 1dcede7 with merge 8d22402...


        Auto merge of #18327 - servo:rustup, r=nox

Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30) Fix this error in the new Rust Nightly: ```rust Compiling script v0.0.1 (file:///home/simon/servo2/components/script) error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10 | 464 | #[derive(JSTraceable)] | ^^^^^^^^^^^ | = note: JSTraceable is a function, perhaps you wish to call it = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `trace`, perhaps you need to implement it: candidate #1: `dom::bindings::trace::JSTraceable` error: aborting due to previous error error: Could not compile `script`. ``` ~I’ve tried to reproduce it in a minimal test case, but `impl<A, B> SomeTrait for fn(A) -> B` did not apply for `fn(&u32) -> u32` even on Rust 1.19.0 stable. So I don’t know what changed.~ This is very likely #18327.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18327)

bors-servo · 2017-09-01T07:40:06Z

💔 Test failed - mac-dev-unit

SimonSapin · 2017-09-01T10:01:15Z

@bors-servo retry #18338

bors-servo · 2017-09-01T12:03:41Z

⌛ Testing commit 1dcede7 with merge 5957016...


        Auto merge of #18327 - servo:rustup, r=nox

Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30) Fix this error in the new Rust Nightly: ```rust Compiling script v0.0.1 (file:///home/simon/servo2/components/script) error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10 | 464 | #[derive(JSTraceable)] | ^^^^^^^^^^^ | = note: JSTraceable is a function, perhaps you wish to call it = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `trace`, perhaps you need to implement it: candidate #1: `dom::bindings::trace::JSTraceable` error: aborting due to previous error error: Could not compile `script`. ``` ~I’ve tried to reproduce it in a minimal test case, but `impl<A, B> SomeTrait for fn(A) -> B` did not apply for `fn(&u32) -> u32` even on Rust 1.19.0 stable. So I don’t know what changed.~ This is very likely #18327.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18327)

jdm · 2017-09-01T17:07:54Z

@bors-servo: retry

bors-servo · 2017-09-01T18:54:10Z

⌛ Testing commit 1dcede7 with merge fd833d9...


        Auto merge of #18327 - servo:rustup, r=nox

Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30) Fix this error in the new Rust Nightly: ```rust Compiling script v0.0.1 (file:///home/simon/servo2/components/script) error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10 | 464 | #[derive(JSTraceable)] | ^^^^^^^^^^^ | = note: JSTraceable is a function, perhaps you wish to call it = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `trace`, perhaps you need to implement it: candidate #1: `dom::bindings::trace::JSTraceable` error: aborting due to previous error error: Could not compile `script`. ``` ~I’ve tried to reproduce it in a minimal test case, but `impl<A, B> SomeTrait for fn(A) -> B` did not apply for `fn(&u32) -> u32` even on Rust 1.19.0 stable. So I don’t know what changed.~ This is very likely #18327.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18327)

bors-servo · 2017-09-01T20:04:52Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing fd833d9 to master...


        servo: Merge #18327 - Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017…

…-08-30) (from servo:rustup); r=nox Fix this error in the new Rust Nightly: ```rust Compiling script v0.0.1 (file:///home/simon/servo2/components/script) error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10 | 464 | #[derive(JSTraceable)] | ^^^^^^^^^^^ | = note: JSTraceable is a function, perhaps you wish to call it = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `trace`, perhaps you need to implement it: candidate #1: `dom::bindings::trace::JSTraceable` error: aborting due to previous error error: Could not compile `script`. ``` ~I’ve tried to reproduce it in a minimal test case, but `impl<A, B> SomeTrait for fn(A) -> B` did not apply for `fn(&u32) -> u32` even on Rust 1.19.0 stable. So I don’t know what changed.~ This is very likely servo/servo#18327. Source-Repo: https://github.com/servo/servo Source-Revision: fd833d9f18cd9196502b9768ab0ac8c1498b2f68


        servo: Merge #18327 - Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017…

…-08-30) (from servo:rustup); r=nox Fix this error in the new Rust Nightly: ```rust Compiling script v0.0.1 (file:///home/simon/servo2/components/script) error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10 | 464 | #[derive(JSTraceable)] | ^^^^^^^^^^^ | = note: JSTraceable is a function, perhaps you wish to call it = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `trace`, perhaps you need to implement it: candidate #1: `dom::bindings::trace::JSTraceable` error: aborting due to previous error error: Could not compile `script`. ``` ~I’ve tried to reproduce it in a minimal test case, but `impl<A, B> SomeTrait for fn(A) -> B` did not apply for `fn(&u32) -> u32` even on Rust 1.19.0 stable. So I don’t know what changed.~ This is very likely servo/servo#18327. Source-Repo: https://github.com/servo/servo Source-Revision: fd833d9f18cd9196502b9768ab0ac8c1498b2f68 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 6abcf458330540d23b69aad3d41f2fe4429fba5a


        servo: Merge #18327 - Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017…

…-08-30) (from servo:rustup); r=nox Fix this error in the new Rust Nightly: ```rust Compiling script v0.0.1 (file:///home/simon/servo2/components/script) error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10 | 464 | #[derive(JSTraceable)] | ^^^^^^^^^^^ | = note: JSTraceable is a function, perhaps you wish to call it = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `trace`, perhaps you need to implement it: candidate #1: `dom::bindings::trace::JSTraceable` error: aborting due to previous error error: Could not compile `script`. ``` ~I’ve tried to reproduce it in a minimal test case, but `impl<A, B> SomeTrait for fn(A) -> B` did not apply for `fn(&u32) -> u32` even on Rust 1.19.0 stable. So I don’t know what changed.~ This is very likely servo/servo#18327. Source-Repo: https://github.com/servo/servo Source-Revision: fd833d9f18cd9196502b9768ab0ac8c1498b2f68


        servo: Merge #18327 - Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017…

…-08-30) (from servo:rustup); r=nox Fix this error in the new Rust Nightly: ```rust Compiling script v0.0.1 (file:///home/simon/servo2/components/script) error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10 | 464 | #[derive(JSTraceable)] | ^^^^^^^^^^^ | = note: JSTraceable is a function, perhaps you wish to call it = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `trace`, perhaps you need to implement it: candidate #1: `dom::bindings::trace::JSTraceable` error: aborting due to previous error error: Could not compile `script`. ``` ~I’ve tried to reproduce it in a minimal test case, but `impl<A, B> SomeTrait for fn(A) -> B` did not apply for `fn(&u32) -> u32` even on Rust 1.19.0 stable. So I don’t know what changed.~ This is very likely servo/servo#18327. Source-Repo: https://github.com/servo/servo Source-Revision: fd833d9f18cd9196502b9768ab0ac8c1498b2f68 UltraBlame original commit: 2093d5141fb21195b1f84894b2921bcace8c3cfd


        servo: Merge #18327 - Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017…

…-08-30) (from servo:rustup); r=nox Fix this error in the new Rust Nightly: ```rust Compiling script v0.0.1 (file:///home/simon/servo2/components/script) error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10 | 464 | #[derive(JSTraceable)] | ^^^^^^^^^^^ | = note: JSTraceable is a function, perhaps you wish to call it = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `trace`, perhaps you need to implement it: candidate #1: `dom::bindings::trace::JSTraceable` error: aborting due to previous error error: Could not compile `script`. ``` ~I’ve tried to reproduce it in a minimal test case, but `impl<A, B> SomeTrait for fn(A) -> B` did not apply for `fn(&u32) -> u32` even on Rust 1.19.0 stable. So I don’t know what changed.~ This is very likely servo/servo#18327. Source-Repo: https://github.com/servo/servo Source-Revision: fd833d9f18cd9196502b9768ab0ac8c1498b2f68 UltraBlame original commit: 2093d5141fb21195b1f84894b2921bcace8c3cfd


        servo: Merge #18327 - Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017…

…-08-30) (from servo:rustup); r=nox Fix this error in the new Rust Nightly: ```rust Compiling script v0.0.1 (file:///home/simon/servo2/components/script) error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the current scope --> /home/simon/servo2/components/script/dom/treewalker.rs:464:10 | 464 | #[derive(JSTraceable)] | ^^^^^^^^^^^ | = note: JSTraceable is a function, perhaps you wish to call it = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `trace`, perhaps you need to implement it: candidate #1: `dom::bindings::trace::JSTraceable` error: aborting due to previous error error: Could not compile `script`. ``` ~I’ve tried to reproduce it in a minimal test case, but `impl<A, B> SomeTrait for fn(A) -> B` did not apply for `fn(&u32) -> u32` even on Rust 1.19.0 stable. So I don’t know what changed.~ This is very likely servo/servo#18327. Source-Repo: https://github.com/servo/servo Source-Revision: fd833d9f18cd9196502b9768ab0ac8c1498b2f68 UltraBlame original commit: 2093d5141fb21195b1f84894b2921bcace8c3cfd

Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30)

Loading status checks…

1dcede7

highfive assigned nox Aug 31, 2017

highfive added the S-awaiting-merge label Aug 31, 2017

SimonSapin mentioned this pull request Aug 31, 2017

Remove the trait selection impl in method::probe rust-lang/rust#43880

Merged

nikomatsakis mentioned this pull request Aug 31, 2017

regression in method dispatch rust-lang/rust#44224

Closed

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 1, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels Sep 1, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 1, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels Sep 1, 2017

highfive removed the S-awaiting-merge label Sep 1, 2017

SimonSapin deleted the rustup branch Sep 11, 2017

SimonSapin mentioned this pull request Jan 4, 2019

tracking issue for "universe transition" rust-lang/rust#56105

Open

SimonSapin mentioned this pull request Feb 27, 2019

script-servo is broken again rust-lang/rustc-perf#354

Closed

servo / servo

Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30) #18327

Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30) #18327

SimonSapin commented Aug 31, 2017 •

edited

SimonSapin commented Aug 31, 2017

bors-servo commented Aug 31, 2017

bors-servo commented Sep 1, 2017

bors-servo commented Sep 1, 2017

SimonSapin commented Sep 1, 2017

bors-servo commented Sep 1, 2017

bors-servo commented Sep 1, 2017

SimonSapin commented Sep 1, 2017

bors-servo commented Sep 1, 2017

jdm commented Sep 1, 2017

bors-servo commented Sep 1, 2017

bors-servo commented Sep 1, 2017

servo / servo

Join GitHub today

Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30) #18327

Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30) #18327

Conversation

SimonSapin commented Aug 31, 2017 • edited

SimonSapin commented Aug 31, 2017

bors-servo commented Aug 31, 2017

bors-servo commented Sep 1, 2017

bors-servo commented Sep 1, 2017

SimonSapin commented Sep 1, 2017

bors-servo commented Sep 1, 2017

bors-servo commented Sep 1, 2017

SimonSapin commented Sep 1, 2017

bors-servo commented Sep 1, 2017

jdm commented Sep 1, 2017

bors-servo commented Sep 1, 2017

bors-servo commented Sep 1, 2017

SimonSapin commented Aug 31, 2017 •

edited