Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse at-rule without block in two stages #18336

Merged
merged 1 commit into from Sep 2, 2017
Merged

Parse at-rule without block in two stages #18336

merged 1 commit into from Sep 2, 2017

Conversation

@upsuper
Copy link
Member

upsuper commented Sep 1, 2017 •
edited by SimonSapin

This is the Servo side change necessary for servo/rust-cssparser#180.

This also pulls in other changes from cssparser 0.20.0.

This change is Reviewable
@highfive
Copy link

highfive commented Sep 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/stylesheets/font_feature_values_rule.rs, components/style/counter_style/mod.rs, components/style/stylesheets/keyframes_rule.rs, components/style/stylesheets/rule_parser.rs and 3 more
  • @canaltinova: components/style/Cargo.toml, components/style/stylesheets/font_feature_values_rule.rs, components/style/counter_style/mod.rs, components/style/stylesheets/keyframes_rule.rs, components/style/stylesheets/rule_parser.rs and 3 more
  • @KiChjang: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
  • @fitzgen: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
  • @emilio: components/style/Cargo.toml, components/style/stylesheets/font_feature_values_rule.rs, components/style/counter_style/mod.rs, components/style/stylesheets/keyframes_rule.rs, components/style/stylesheets/rule_parser.rs and 4 more
@upsuper
Copy link
Member Author

upsuper commented Sep 1, 2017

r? @SimonSapin
@highfive highfive assigned SimonSapin and unassigned asajeffrey Sep 1, 2017
@upsuper
Copy link
Member Author

upsuper commented Sep 1, 2017

This should fix bug 1388911. Maybe we need to update wpt expectation in Servo as well.
@upsuper upsuper force-pushed the upsuper-forks:two-stage-at-rule branch from d9a20e3 to 7619aaa Sep 1, 2017
@upsuper
Copy link
Member Author

upsuper commented Sep 1, 2017

Updated with [patch.cartes-io] included so that we can run try.

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

⌛ Trying commit 7619aaa with merge 08842f62cb0665c6dff81ae88b60cf300de66309...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

💔 Test failed - linux-rel-wpt
@upsuper upsuper force-pushed the upsuper-forks:two-stage-at-rule branch from 7619aaa to 8c87d3f Sep 1, 2017
@highfive highfive removed the S-tests-failed label Sep 1, 2017
@upsuper
Copy link
Member Author

upsuper commented Sep 1, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

⌛ Trying commit 8c87d3f with merge 8c12d5bbc433aedb486b541ca925dd4065864aba...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

💔 Test failed - mac-rel-wpt1
@upsuper
Copy link
Member Author

upsuper commented Sep 1, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

⌛ Trying commit 8c87d3f with merge 9641fd1abbf626aced61fa7d83b52e2f370f2dc4...
@SimonSapin SimonSapin mentioned this pull request Sep 1, 2017
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

💔 Test failed - mac-rel-wpt2
@upsuper
Copy link
Member Author

upsuper commented Sep 1, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

⌛ Trying commit 8c87d3f with merge 88ce559...
bors-servo added a commit that referenced this pull request Sep 1, 2017
@bors-servo
Auto merge of #18336 - upsuper:two-stage-at-rule, r=<try>
Loading status checks…
88ce559 
[WIP] Parse at-rule without block in two stages

This is the Servo side change necessary for servo/rust-cssparser#180.

Cargo.lock inside needs to be updated before landing after new version of cssparser gets published.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18336)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

💔 Test failed - mac-rel-wpt4
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

💔 Test failed - mac-rel-wpt3
@SimonSapin SimonSapin closed this Sep 1, 2017
@SimonSapin SimonSapin reopened this Sep 1, 2017
@SimonSapin
Copy link
Member

SimonSapin commented Sep 1, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

⌛ Testing commit 2bca620 with merge b97278f...
bors-servo added a commit that referenced this pull request Sep 1, 2017
@bors-servo
Auto merge of #18336 - upsuper:two-stage-at-rule, r=SimonSapin
Loading status checks…
b97278f 
Parse at-rule without block in two stages

This is the Servo side change necessary for servo/rust-cssparser#180.

----

This also pulls in other changes from cssparser 0.20.0.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18336)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

💔 Test failed - mac-dev-unit
@SimonSapin
Copy link
Member

SimonSapin commented Sep 1, 2017

@bors-servo retry #18338

Sigh
@SimonSapin
Copy link
Member

SimonSapin commented Sep 1, 2017

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd0d6f69ea85132902ca91486dc8145742c41c12
@SimonSapin
Copy link
Member

SimonSapin commented Sep 1, 2017

This makes two copies of a previously-failing Gecko test pass:

PASS (expected FAIL) | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-namespaces-3/syntax-013.xml
PASS (expected FAIL) | /css/css-namespaces-3/syntax-013.xml Testing http://web-platform.test:8000/css/css-namespaces-3/syntax-013.xml
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

⌛ Testing commit 2bca620 with merge f2e5b49...
bors-servo added a commit that referenced this pull request Sep 1, 2017
@bors-servo
Auto merge of #18336 - upsuper:two-stage-at-rule, r=SimonSapin
Loading status checks…
f2e5b49 
Parse at-rule without block in two stages

This is the Servo side change necessary for servo/rust-cssparser#180.

----

This also pulls in other changes from cssparser 0.20.0.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18336)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing f2e5b49 to master...
@bors-servo bors-servo merged commit 2bca620 into servo:master Sep 2, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper-forks:two-stage-at-rule branch Sep 2, 2017
xeonchen pushed a commit to xeonchen/gecko-cinnabar that referenced this pull request Sep 2, 2017
@upsuper
Bug 1388911 - Update expectation for this bug after landing servo/ser…
ef82fa7 
…vo#18336.

MozReview-Commit-ID: EMKg34csW4l
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 2, 2017
@upsuper
Bug 1388911 - Update expectation for this bug after landing servo/ser…
d57b5bd 
…vo#18336.

MozReview-Commit-ID: EMKg34csW4l
aethanyc pushed a commit to aethanyc/gecko-dev that referenced this pull request Sep 3, 2017
@upsuper
Bug 1388911 - Update expectation for this bug after landing servo/ser…
c222126 
…vo#18336.

MozReview-Commit-ID: EMKg34csW4l
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
Bug 1388911 - Update expectation for this bug after landing servo/ser…
cee3db7 
…vo#18336.

MozReview-Commit-ID: EMKg34csW4l

UltraBlame original commit: c057e3b320f0004ac0eef7be636295fc4be3911b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
Bug 1388911 - Update expectation for this bug after landing servo/ser…
1649bac 
…vo#18336.

MozReview-Commit-ID: EMKg34csW4l

UltraBlame original commit: c057e3b320f0004ac0eef7be636295fc4be3911b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
@marco-c
Bug 1388911 - Update expectation for this bug after landing servo/ser…
a63ceca 
…vo#18336.

MozReview-Commit-ID: EMKg34csW4l

UltraBlame original commit: c057e3b320f0004ac0eef7be636295fc4be3911b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@upsuper @highfive @bors-servo @SimonSapin @heycam @asajeffrey
You can’t perform that action at this time.