Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added direct link to Visual Studio Community #18348

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
6 participants
@BojanKogoj
Copy link
Contributor

commented Sep 1, 2017


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Sep 1, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.

@atouchet

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2017

I don't think this is really necessary. There's already a direct download link on the main page.

@BojanKogoj

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2017

@atouchet fair point, although it wasn't obvious to me that that was community edition

@asajeffrey

This comment has been minimized.

Copy link
Member

commented Sep 11, 2017

Is there a consensus about this?

@jdm

This comment has been minimized.

Copy link
Member

commented Sep 11, 2017

This seems like a reasonable choice to me.

@asajeffrey

This comment has been minimized.

Copy link
Member

commented Sep 11, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2017

📌 Commit e878e8f has been approved by asajeffrey

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2017

⌛️ Testing commit e878e8f with merge ac2fd02...

bors-servo added a commit that referenced this pull request Sep 11, 2017

Auto merge of #18348 - BojanKogoj:patch-1, r=asajeffrey
Added direct link to Visual Studio Community

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18348)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2017

@bors-servo bors-servo merged commit e878e8f into servo:master Sep 11, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.