Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow interpolating SVGPaintKind::None. #18364

Merged
merged 1 commit into from Sep 4, 2017

Conversation

@mantaroh
Copy link
Contributor

commented Sep 4, 2017

This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1396483

PR #18103 disallowed interpolation between fill:none and fill:none, but that change was regressed by the refactoring in PR #18239.
This patch restores the intended behavior, disabling animation of SVGPaintKind::None.


  • [ x ] ./mach build -d does not report any errors
  • [ x ] ./mach test-tidy does not report any errors

There are already these tests in dom/smil/tests of gecko, this PR will enable these tests.
For detail, see https://bugzilla.mozilla.org/show_bug.cgi?id=1396483 .


This change is Reviewable

PR #18103 disallowed interpolation between fill:none and fill:none, but that change was regressed by the refactoring in PR #18239.
This patch restores the intended behavior, disabling animation of SVGPaintKind::None.
@highfive

This comment has been minimized.

Copy link

commented Sep 4, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/generics/svg.rs
  • @canaltinova: components/style/values/generics/svg.rs
  • @emilio: components/style/values/generics/svg.rs
@highfive

This comment has been minimized.

Copy link

commented Sep 4, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@mantaroh

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2017

This patch have been reviewed by @birtles

@emilio

This comment has been minimized.

Copy link
Member

commented Sep 4, 2017

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2017

✌️ @mantaroh can now approve this pull request

@mantaroh

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2017

Thanks @emilio !

@mantaroh

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2017

@bors-servo r=birtles p=10

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2017

📌 Commit d37b5c3 has been approved by birtles

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2017

⌛️ Testing commit d37b5c3 with merge e5efbee...

bors-servo added a commit that referenced this pull request Sep 4, 2017
Don't allow interpolating SVGPaintKind::None.

This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1396483

PR #18103 disallowed interpolation between fill:none and fill:none, but that change was regressed by the refactoring in PR #18239.
This patch restores the intended behavior, disabling animation of SVGPaintKind::None.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ x ] `./mach build -d` does not report any errors
- [ x ] `./mach test-tidy` does not report any errors

<!-- Either: -->
There are already these tests in dom/smil/tests of gecko, this PR will enable these tests.
For detail, see https://bugzilla.mozilla.org/show_bug.cgi?id=1396483 .

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18364)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2017

@bors-servo bors-servo merged commit d37b5c3 into servo:master Sep 4, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.