Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport None and NotSet for the fallback type of SVGPaint. #18376
Conversation
highfive
commented
Sep 5, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 5, 2017
|
|
|
@bors-servo delegate+ |
|
|
|
@bors-servo r=xidorn |
|
|
|
This has been reviewed by @upsuper in Bug 1380590 |
bors-servo
added a commit
that referenced
this pull request
Sep 5, 2017
…ck-color-of-context-property-is-none, r=xidorn Support None and NotSet for the fallback type of SVGPaint. <!-- Please describe your changes on the following line: --> We didn't set None and NotSet for the fallback type of SVGPaint, and it caused the fallback color is wrong when fallback color is empty or keyword `none`. So, we add the None and NotSet support for it. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [Bug 1380590](https://bugzilla.mozilla.org/show_bug.cgi?id=1380590) <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because of the test cases already in Gecko. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18376) <!-- Reviewable:end -->
|
|
|
#18374....:( |
|
This can be retried now. |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Sep 6, 2017
…ck-color-of-context-property-is-none, r=xidorn Support None and NotSet for the fallback type of SVGPaint. <!-- Please describe your changes on the following line: --> We didn't set None and NotSet for the fallback type of SVGPaint, and it caused the fallback color is wrong when fallback color is empty or keyword `none`. So, we add the None and NotSet support for it. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [Bug 1380590](https://bugzilla.mozilla.org/show_bug.cgi?id=1380590) <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because of the test cases already in Gecko. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18376) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kuoe0 commentedSep 5, 2017
•
edited
We didn't set None and NotSet for the fallback type of SVGPaint, and it caused the fallback color is wrong when fallback color is empty or keyword
none. So, we add the None and NotSet support for it../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is