Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CEReactions to element creation APIs. #18382

Merged
merged 1 commit into from Sep 6, 2017

Conversation

@jdm
Copy link
Member

commented Sep 5, 2017

This addresses whatwg/dom#506.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they will exist upstream in the future.

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Sep 5, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/webidls/Document.webidl
  • @KiChjang: components/script/dom/webidls/Document.webidl
@highfive

This comment has been minimized.

Copy link

commented Sep 5, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@cbrewster

This comment has been minimized.

Copy link
Member

commented Sep 6, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

📌 Commit 90ff099 has been approved by cbrewster

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

⌛️ Testing commit 90ff099 with merge 0525214...

bors-servo added a commit that referenced this pull request Sep 6, 2017
Add CEReactions to element creation APIs.

This addresses whatwg/dom#506.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they will exist upstream in the future.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18382)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

💔 Test failed - linux-rel-css

@jdm

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2017

@bors-servo retry

  • Known webrender intermittent
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

⌛️ Testing commit 90ff099 with merge 4ada03f...

bors-servo added a commit that referenced this pull request Sep 6, 2017
Add CEReactions to element creation APIs.

This addresses whatwg/dom#506.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they will exist upstream in the future.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18382)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

@bors-servo bors-servo merged commit 90ff099 into master Sep 6, 2017
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-1 branch Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.