Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Don't waste a whole selector map for each class / id in the document. #18384

Merged
merged 3 commits into from Sep 5, 2017

Conversation

@emilio
Copy link
Member

commented Sep 5, 2017

On top of #18375, only last commit needs review.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Sep 5, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/data.rs, components/style/gecko/generated/structs_debug.rs, components/style/stylesheets/memory.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs and 9 more
  • @canaltinova: components/style/gecko/data.rs, components/style/gecko/generated/structs_debug.rs, components/style/stylesheets/memory.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs and 9 more
@highfive

This comment has been minimized.

Copy link

commented Sep 5, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2017

@highfive highfive assigned bholley and unassigned jdm Sep 5, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

☔️ The latest upstream changes (presumably #18365) made this pull request unmergeable. Please resolve the merge conflicts.

nnethercote and others added 3 commits Sep 5, 2017
…cument.

It's just useless.
…enum.
@emilio emilio force-pushed the emilio:invalidation-map-bloat branch from c62bb2c to cdbb5b5 Sep 5, 2017
@bholley

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

@bors-servo r+ p=10 force

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

📌 Commit cdbb5b5 has been approved by bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

⌛️ Testing commit cdbb5b5 with merge 4721ef8...

bors-servo added a commit that referenced this pull request Sep 5, 2017
style: Don't waste a whole selector map for each class / id in the document.

On top of #18375, only last commit needs review.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18384)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

@bors-servo bors-servo merged commit cdbb5b5 into servo:master Sep 5, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@emilio emilio referenced this pull request Sep 6, 2017
3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.