Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean imports in hashglobe #18385

Merged
merged 1 commit into from Sep 6, 2017
Merged

Clean imports in hashglobe #18385

merged 1 commit into from Sep 6, 2017

Conversation

@Manishearth
Copy link
Member

Manishearth commented Sep 5, 2017

This change is Reviewable

use std::hash::{Hash, BuildHasher};
use std::iter::FromIterator;
use std::mem::{self, replace};
use std::ops::{Deref, Index};
#[allow(deprecated)]

This comment has been minimized.

@mbrubeck

mbrubeck Sep 5, 2017

Contributor

This got got detached from its use statement.

@Manishearth Manishearth force-pushed the Manishearth:clean-imports branch from 306159b to 02fe616 Sep 5, 2017
@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 5, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2017

📌 Commit 02fe616 has been approved by mbrubeck

@highfive highfive assigned mbrubeck and unassigned jdm Sep 5, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 6, 2017

Testing commit 02fe616 with merge 0b87d8d...

bors-servo added a commit that referenced this pull request Sep 6, 2017
Clean imports in hashglobe

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18385)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 6, 2017

💔 Test failed - linux-rel-wpt

@Manishearth
Copy link
Member Author

Manishearth commented Sep 6, 2017

@bors-servo retry

{"status": "FAIL", "group": "default", "message": "/_mozilla/css/css-position-3/position-sticky-table-th-left.html 6989f695a802d6b00630a8e7a361ac83382756d0\n/_mozilla/css/css-position-3/position-sticky-table-th-left-ref.html a75f0e1a5e75cd58ca571efe3893dbd431c3f6f6\nTesting 6989f695a802d6b00630a8e7a361ac83382756d0 == a75f0e1a5e75cd58ca571efe3893dbd431c3f6f6", "stack": null, "subtest": null, "test": "/_mozilla/css/css-position-3/position-sticky-table-th-left.html", "line": 69873, "action": "test_result", "expected": "PASS"}
@bors-servo
Copy link
Contributor

bors-servo commented Sep 6, 2017

Testing commit 02fe616 with merge f29fd77...

bors-servo added a commit that referenced this pull request Sep 6, 2017
Clean imports in hashglobe

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18385)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 6, 2017

@bors-servo bors-servo merged commit 02fe616 into servo:master Sep 6, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:clean-imports branch Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.