Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure SmallVecs in SelectorMap and InvalidationMap. #18387

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
4 participants
@nnethercote
Copy link
Contributor

commented Sep 6, 2017

This is another ~300 KiB on the Obama wikipedia page.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because testing is on the Gecko side.

r? @heycam


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Sep 6, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/invalidation/element/invalidation_map.rs, components/style/stylesheets/memory.rs, components/style/selector_map.rs, components/style/stylist.rs
  • @canaltinova: components/style/invalidation/element/invalidation_map.rs, components/style/stylesheets/memory.rs, components/style/selector_map.rs, components/style/stylist.rs
  • @emilio: components/style/invalidation/element/invalidation_map.rs, components/style/stylesheets/memory.rs, components/style/selector_map.rs, components/style/stylist.rs
@highfive

This comment has been minimized.

Copy link

commented Sep 6, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@heycam

This comment has been minimized.

Copy link
Member

commented Sep 6, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

📌 Commit ae1216a has been approved by heycam

@heycam

This comment has been minimized.

Copy link
Member

commented Sep 6, 2017

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

✌️ @nnethercote can now approve this pull request

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

⌛️ Testing commit ae1216a with merge 6051e5e...

bors-servo added a commit that referenced this pull request Sep 6, 2017

Auto merge of #18387 - nnethercote:measure-smallvec, r=heycam
Measure SmallVecs in SelectorMap and InvalidationMap.

<!-- Please describe your changes on the following line: -->

This is another ~300 KiB on the Obama wikipedia page.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because testing is on the Gecko side.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @heycam

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18387)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

@bors-servo bors-servo merged commit ae1216a into servo:master Sep 6, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@nnethercote nnethercote deleted the nnethercote:measure-smallvec branch Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.