Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Stop the cascade when only reset structs change #18391

Merged
merged 7 commits into from Sep 6, 2017

Conversation

Projects
None yet
5 participants
@emilio
Copy link
Member

commented Sep 6, 2017

@highfive

This comment has been minimized.

Copy link

commented Sep 6, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/traversal.rs, components/style/style_adjuster.rs, components/style/gecko/restyle_damage.rs, components/style/servo/restyle_damage.rs and 3 more
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/traversal.rs, components/style/style_adjuster.rs, components/style/gecko/restyle_damage.rs, components/style/servo/restyle_damage.rs and 3 more
@highfive

This comment has been minimized.

Copy link

commented Sep 6, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

emilio added some commits Sep 4, 2017

style: Stop the cascade when only reset structs change.
Bug: 1395227
Reviewed-by: heycam
MozReview-Commit-ID: JCZJl2fmtJ9
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
style: Fix the legacy value of justify-items propagation.
That property is pretty sad :(

MozReview-Commit-ID: GaKYvqR19M4
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
style: Fix recascading when child blockification depends on our displ…
…ay value.

All other browsers get it right because they basically throw away all the styles
in a subtree after a display change. We do better, but need to do this check.

MozReview-Commit-ID: BODx0gnSzwI
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
style: Reindent some code.
MozReview-Commit-ID: H2qucldbBkc
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
style: Handle correctly display changes from ruby to non-ruby in some…
… edge cases.

And add comments to the reset-property-dependent adjustments.

MozReview-Commit-ID: Li6Epx8k5x8
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>

@emilio emilio force-pushed the emilio:cascade-stoph branch from 39efc17 to 03517ea Sep 6, 2017

@emilio

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2017

@bors-servo r=heycam p=1

  • Coordiland
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

📌 Commit 03517ea has been approved by heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

⌛️ Testing commit 03517ea with merge c95446503e616bcd2cc827ca8a6aeec7440ea0e7...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

💔 Test failed - linux-dev

@emilio emilio force-pushed the emilio:cascade-stoph branch from 03517ea to d8234fe Sep 6, 2017

@emilio

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2017

@bors-servo r=heycam

  • I updated the whole thing instead of just the functions.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

📌 Commit d8234fe has been approved by heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

⌛️ Testing commit d8234fe with merge ef5736e...

bors-servo added a commit that referenced this pull request Sep 6, 2017

Auto merge of #18391 - emilio:cascade-stoph, r=heycam
style: Stop the cascade when only reset structs change

From https://bugzilla.mozilla.org/show_bug.cgi?id=1395227

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18391)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

💔 Test failed - linux-rel-wpt

@emilio

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

@emilio

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2017

@bors-servo r=heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

📌 Commit ac2be54 has been approved by heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

⌛️ Testing commit ac2be54 with merge 9802214...

bors-servo added a commit that referenced this pull request Sep 6, 2017

Auto merge of #18391 - emilio:cascade-stoph, r=heycam
style: Stop the cascade when only reset structs change

From https://bugzilla.mozilla.org/show_bug.cgi?id=1395227

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18391)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

@bors-servo bors-servo merged commit ac2be54 into servo:master Sep 6, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@emilio emilio deleted the emilio:cascade-stoph branch Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.