Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Stop the cascade when only reset structs change #18391

Merged
merged 7 commits into from Sep 6, 2017
Merged

style: Stop the cascade when only reset structs change #18391

merged 7 commits into from Sep 6, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Sep 6, 2017 •
edited by SimonSapin

@highfive
Copy link

highfive commented Sep 6, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/traversal.rs, components/style/style_adjuster.rs, components/style/gecko/restyle_damage.rs, components/style/servo/restyle_damage.rs and 3 more
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/traversal.rs, components/style/style_adjuster.rs, components/style/gecko/restyle_damage.rs, components/style/servo/restyle_damage.rs and 3 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 6, 2017
@highfive
Copy link

highfive commented Sep 6, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@emilio
style: Stop the cascade when only reset structs change.
825f623 
Bug: 1395227
Reviewed-by: heycam
MozReview-Commit-ID: JCZJl2fmtJ9
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio
style: Fix the legacy value of justify-items propagation.
35504c1 
That property is pretty sad :(

MozReview-Commit-ID: GaKYvqR19M4
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio
style: Fix recascading when child blockification depends on our displ…
05371b5 
…ay value.

All other browsers get it right because they basically throw away all the styles
in a subtree after a display change. We do better, but need to do this check.

MozReview-Commit-ID: BODx0gnSzwI
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio
style: Reindent some code.
deefacc 
MozReview-Commit-ID: H2qucldbBkc
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio
style: Handle correctly display changes from ruby to non-ruby in some…
7d2e2e2 
… edge cases.

And add comments to the reset-property-dependent adjustments.

MozReview-Commit-ID: Li6Epx8k5x8
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio
Copy link
Member Author

emilio commented Sep 6, 2017

@bors-servo r=heycam p=1

  • Coordiland

@bors-servo
Copy link
Contributor

📌 Commit 03517ea has been approved by heycam

@highfive highfive assigned heycam and unassigned wafflespeanut Sep 6, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 6, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 03517ea with merge c95446503e616bcd2cc827ca8a6aeec7440ea0e7...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 6, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 6, 2017
@emilio
Copy link
Member Author

emilio commented Sep 6, 2017

@bors-servo r=heycam

  • I updated the whole thing instead of just the functions.

@bors-servo
Copy link
Contributor

📌 Commit d8234fe has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 6, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit d8234fe with merge ef5736e...

bors-servo pushed a commit that referenced this pull request Sep 6, 2017
Auto merge of #18391 - emilio:cascade-stoph, r=heycam
ef5736e 
style: Stop the cascade when only reset structs change

From https://bugzilla.mozilla.org/show_bug.cgi?id=1395227

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18391)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 6, 2017
@emilio
Copy link
Member Author

emilio commented Sep 6, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt4...

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 6, 2017
@emilio
Copy link
Member Author

emilio commented Sep 6, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit ac2be54 has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 6, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit ac2be54 with merge 9802214...

bors-servo pushed a commit that referenced this pull request Sep 6, 2017
Auto merge of #18391 - emilio:cascade-stoph, r=heycam
9802214 
style: Stop the cascade when only reset structs change

From https://bugzilla.mozilla.org/show_bug.cgi?id=1395227

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18391)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing 9802214 to master...

@bors-servo bors-servo merged commit ac2be54 into servo:master Sep 6, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 6, 2017
@emilio emilio deleted the cascade-stoph branch September 6, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emilio @highfive @bors-servo @heycam @wafflespeanut