Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_property_value unsafe #18393

Merged
merged 1 commit into from Sep 7, 2017

Conversation

@nox
Copy link
Member

commented Sep 6, 2017

This takes raw pointers and does things with the things they point to, and
circumvent a lock on a hash table.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Sep 6, 2017

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

Copy link

commented Sep 6, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@emilio

This comment has been minimized.

Copy link
Member

commented Sep 6, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

📌 Commit 6aa1ca0 has been approved by emilio

@highfive highfive assigned emilio and unassigned cbrewster Sep 6, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

⌛️ Testing commit 6aa1ca0 with merge cb2d2ad...

bors-servo added a commit that referenced this pull request Sep 6, 2017
Make get_property_value unsafe

This takes raw pointers and does things with the things they point to, and
circumvent a lock on a hash table.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18393)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

💔 Test failed - windows-msvc-dev

This takes raw pointers and does things with the things they point to, and
circumvent a lock on a hash table.
@nox nox force-pushed the get-property-value-unsafe branch from 6aa1ca0 to 83904ed Sep 7, 2017
@emilio

This comment has been minimized.

Copy link
Member

commented Sep 7, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2017

📌 Commit 83904ed has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2017

⌛️ Testing commit 83904ed with merge 5defc56...

bors-servo added a commit that referenced this pull request Sep 7, 2017
Make get_property_value unsafe

This takes raw pointers and does things with the things they point to, and
circumvent a lock on a hash table.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18393)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2017

💔 Test failed - linux-rel-wpt

@nox

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2017

@bors-servo bors-servo merged commit 83904ed into master Sep 7, 2017
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
dependency-ci Checking Dependencies
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the get-property-value-unsafe branch Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.