Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report more specific error for invalid filter properties #18394

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
4 participants
@jdm
Copy link
Member

commented Sep 6, 2017

Reviewed by xidorn in https://bugzilla.mozilla.org/show_bug.cgi?id=1386900.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix bug 1386900.
  • There are tests for these changes

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Sep 6, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/effects.rs
  • @canaltinova: components/style/values/specified/effects.rs
  • @emilio: ports/geckolib/error_reporter.rs, components/style/values/specified/effects.rs
@highfive

This comment has been minimized.

Copy link

commented Sep 6, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@jdm

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2017

@bors-servo: r=xidorn p=1

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

📌 Commit 6827a10 has been approved by xidorn

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

⌛️ Testing commit 6827a10 with merge a7ea674...

bors-servo added a commit that referenced this pull request Sep 6, 2017

Auto merge of #18394 - jdm:filtererr, r=xidorn
Report more specific error for invalid filter properties

Reviewed by xidorn in https://bugzilla.mozilla.org/show_bug.cgi?id=1386900.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [bug 1386900](https://bugzilla.mozilla.org/show_bug.cgi?id=1386900).
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18394)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2017

@bors-servo bors-servo merged commit 6827a10 into servo:master Sep 6, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.