Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upharfbuzz-sys update #18410
harfbuzz-sys update #18410
Conversation
|
@mbrubeck r? |
|
@bors-servo r+ |
|
|
|
@bors-servo retry |
harfbuzz-sys update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
harfbuzz-sys update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410) <!-- Reviewable:end -->
|
|
|
These might be actual behavior changes caused by servo/rust-harfbuzz#78:
|
|
I think that all these tests were "accidentally passing" before through a combination of lack of fonts and out of date harfbuzz. Feel free to update the test metadata and file a follow-up bug about the failures. |
|
I cannot reproduce locally. I'm blindly updating the manifest see if it works. |
|
@mbrubeck any idea what went wrong? |
|
@bors-servo retry I can't reproduce the build failures locally. |
|
@mbrubeck I can't reproduce the failure locally. Do you know if it's failing to compile because of the servo/rust-harfbuzz#78 or servo/rust-harfbuzz#80 ? |
|
@bors-servo try |
|
|
|
|
|
@bors-servo: retry |
harfbuzz-sys update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410) <!-- Reviewable:end -->
|
|
|
|
That matches the Mac results from last time; it looks like several of these test failures ( |
|
Ok. Now it's working. Can someone r+ this? |
|
@bors-servo r+ |
|
|
harfbuzz-sys update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410) <!-- Reviewable:end -->
|
|
|
@bors-servo treeclosed- |
harfbuzz-sys update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410) <!-- Reviewable:end -->
|
|
paulrouget commentedSep 7, 2017
•
edited by SimonSapin
This change is