Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harfbuzz-sys update #18410

Merged
merged 1 commit into from Sep 15, 2017
Merged

harfbuzz-sys update #18410

merged 1 commit into from Sep 15, 2017

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Sep 7, 2017

This change is Reviewable

@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 7, 2017

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 7, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

📌 Commit 5f17f09 has been approved by mbrubeck

@highfive highfive assigned mbrubeck and unassigned emilio Sep 7, 2017
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 7, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

Testing commit 5f17f09 with merge 71e1628...

bors-servo added a commit that referenced this pull request Sep 7, 2017
harfbuzz-sys update

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

💔 Test failed - mac-rel-wpt2

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 7, 2017

@bors-servo retry

  • infra?
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

Testing commit 5f17f09 with merge 093bd1b...

bors-servo added a commit that referenced this pull request Sep 7, 2017
harfbuzz-sys update

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

💔 Test failed - linux-rel-css

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 7, 2017

These might be actual behavior changes caused by servo/rust-harfbuzz#78:

  ▶ PASS [expected FAIL] /css-text-3_dev/html/word-break-break-all-008.htm

  ▶ FAIL [expected PASS] /css-text-3_dev/html/word-break-break-all-007.htm
  └   → /css-text-3_dev/html/word-break-break-all-007.htm 95da652e9d0cdadddf6e9bafaf1731634148d0ad
/css-text-3_dev/html/reference/word-break-break-all-ref-007.htm d192e2ee5ae282f00d2da7baf2995dea2d5ef85d
Testing 95da652e9d0cdadddf6e9bafaf1731634148d0ad == d192e2ee5ae282f00d2da7baf2995dea2d5ef85d

  ▶ FAIL [expected PASS] /css-text-3_dev/html/word-break-normal-bo-000.htm
  └   → /css-text-3_dev/html/word-break-normal-bo-000.htm b1818170ff108bd50214e99c2b4b67a2f4704e9f
/css-text-3_dev/html/reference/word-break-normal-bo-ref-000.htm 1b833a5263158622e7bf32f854f5e5a5f009420d
Testing b1818170ff108bd50214e99c2b4b67a2f4704e9f == 1b833a5263158622e7bf32f854f5e5a5f009420d

  ▶ FAIL [expected PASS] /css-text-3_dev/html/word-break-normal-hi-000.htm
  └   → /css-text-3_dev/html/word-break-normal-hi-000.htm ebe9ce78534f2ffe9f03a450a0963f0ae8b9a933
/css-text-3_dev/html/reference/word-break-normal-hi-ref-000.htm 0f747c946f460cb80065f9e4d5baad2f3ed259da
Testing ebe9ce78534f2ffe9f03a450a0963f0ae8b9a933 == 0f747c946f460cb80065f9e4d5baad2f3ed259da
@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 7, 2017

test-css failed on Mac with a different error:

  ▶ FAIL [expected PASS] /css-text-3_dev/html/word-break-normal-bo-000.htm
  └   → /css-text-3_dev/html/word-break-normal-bo-000.htm 5924dfb037ea00360d59ed709909d759eafb1948
/css-text-3_dev/html/reference/word-break-normal-bo-ref-000.htm 2c48ccbe00b5d470da2ad0a5fde778d46ee879e6
Testing 5924dfb037ea00360d59ed709909d759eafb1948 == 2c48ccbe00b5d470da2ad0a5fde778d46ee879e6

I think that all these tests were "accidentally passing" before through a combination of lack of fonts and out of date harfbuzz. Feel free to update the test metadata and file a follow-up bug about the failures.

@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 8, 2017

I cannot reproduce locally. I'm blindly updating the manifest see if it works.

@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 8, 2017

@mbrubeck any idea what went wrong?

@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 9, 2017

@bors-servo retry

I can't reproduce the build failures locally.

@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 11, 2017

@mbrubeck I can't reproduce the failure locally. Do you know if it's failing to compile because of the servo/rust-harfbuzz#78 or servo/rust-harfbuzz#80 ?

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 13, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2017

Trying commit dffb2d6 with merge 50cd17c975655b0fe42e079b887fc6ad6794da6d...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2017

💥 Test timed out

@jdm
Copy link
Member

jdm commented Sep 14, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2017

Trying commit dffb2d6 with merge 091871b...

bors-servo added a commit that referenced this pull request Sep 14, 2017
harfbuzz-sys update

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2017

💔 Test failed - mac-rel-css1

@jdm
Copy link
Member

jdm commented Sep 14, 2017

{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/css-text-3_dev/html/word-break-break-all-007.htm", "line": 13802, "action": "test_result", "expected": "FAIL"}
{"status": "FAIL", "group": "default", "message": "/css-text-3_dev/html/word-break-break-all-008.htm 85d61c419cd6708197e352364dce716dd2ead0a1\n/css-text-3_dev/html/reference/word-break-break-all-ref-008.htm 9ca1d270e6fdcca72951b5e0d2044ee7cb950321\nTesting 85d61c419cd6708197e352364dce716dd2ead0a1 == 9ca1d270e6fdcca72951b5e0d2044ee7cb950321", "stack": null, "subtest": null, "test": "/css-text-3_dev/html/word-break-break-all-008.htm", "line": 13832, "action": "test_result", "expected": "PASS"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/css-text-3_dev/html/word-break-normal-hi-000.htm", "line": 13911, "action": "test_result", "expected": "FAIL"}
@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 14, 2017

That matches the Mac results from last time; it looks like several of these test failures (all-007, all-008, and normal-hi-000) need to be marked platform-specific.

@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 15, 2017

Ok. Now it's working.

Can someone r+ this?

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 15, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2017

📌 Commit d0e9ad6 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2017

Testing commit d0e9ad6 with merge 1600647...

bors-servo added a commit that referenced this pull request Sep 15, 2017
harfbuzz-sys update

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2017

The build was interrupted to prioritize another pull request.

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 15, 2017

@bors-servo treeclosed-

@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2017

Testing commit d0e9ad6 with merge 564fb5c...

bors-servo added a commit that referenced this pull request Sep 15, 2017
harfbuzz-sys update

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2017

@bors-servo bors-servo merged commit d0e9ad6 into servo:master Sep 15, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.