Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump app_units; use from_f64_au #18413

Merged
merged 1 commit into from Sep 8, 2017
Merged

Bump app_units; use from_f64_au #18413

merged 1 commit into from Sep 8, 2017
+27 −33

Conversation

@Manishearth
Copy link
Member

Manishearth commented Sep 7, 2017 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Sep 7, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/values/specified/length.rs
  • @canaltinova: components/style/Cargo.toml, components/style/values/specified/length.rs
  • @emilio: components/style/Cargo.toml, components/style/values/specified/length.rs
@highfive
Copy link

highfive commented Sep 7, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Sep 7, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

📌 Commit b7a3684 has been approved by jdm
@highfive highfive assigned jdm and unassigned wafflespeanut Sep 7, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

⌛ Testing commit b7a3684 with merge ce495273e92b68950bc50ac090530f852e981a16...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

💔 Test failed - mac-rel-wpt4
@Manishearth Manishearth force-pushed the Manishearth:bump-au branch from b7a3684 to dd878ee Sep 8, 2017
@Manishearth
Copy link
Member Author

Manishearth commented Sep 8, 2017

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

📌 Commit dd878ee has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

⌛ Testing commit dd878ee with merge 30a9e30...
bors-servo added a commit that referenced this pull request Sep 8, 2017
@bors-servo
Auto merge of #18413 - Manishearth:bump-au, r=jdm
Loading status checks…
30a9e30 
Bump app_units; use from_f64_au

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18413)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

💔 Test failed - linux-dev
@wafflespeanut
Copy link
Member

wafflespeanut commented Sep 8, 2017 

error[E0277]: the trait bound `f32: std::ops::Mul<i32>` is not satisfied
   --> /home/servo/buildbot/slave/linux-dev/build/components/style/values/specified/length.rs:357:32
    |
357 |         au_from_f32_round(inch * physical_inch)
    |                                ^ no implementation for `f32 * i32`
    |
    = help: the trait `std::ops::Mul<i32>` is not implemented for `f32`

error: aborting due to previous error(s)

error: Could not compile `style`.
@Manishearth
Bump app_units; use from_f64_au
Loading status checks…
489bbb8
@Manishearth Manishearth force-pushed the Manishearth:bump-au branch from dd878ee to 489bbb8 Sep 8, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

⌛ Testing commit 489bbb8 with merge f295cd3...
bors-servo added a commit that referenced this pull request Sep 8, 2017
@bors-servo
Auto merge of #18413 - Manishearth:bump-au, r=jdm
Loading status checks…
f295cd3 
Bump app_units; use from_f64_au

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18413)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

💔 Test failed - linux-rel-wpt
@Manishearth
Copy link
Member Author

Manishearth commented Sep 8, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

⌛ Testing commit 489bbb8 with merge b640bac...
bors-servo added a commit that referenced this pull request Sep 8, 2017
@bors-servo
Auto merge of #18413 - Manishearth:bump-au, r=jdm
Loading status checks…
b640bac 
Bump app_units; use from_f64_au

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18413)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

💔 Test failed - linux-rel-wpt
@Manishearth
Copy link
Member Author

Manishearth commented Sep 8, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

⌛ Testing commit 489bbb8 with merge 2b73735...
bors-servo added a commit that referenced this pull request Sep 8, 2017
@bors-servo
Auto merge of #18413 - Manishearth:bump-au, r=jdm
Loading status checks…
2b73735 
Bump app_units; use from_f64_au

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18413)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

💔 Test failed - linux-rel-wpt
@Manishearth
Copy link
Member Author

Manishearth commented Sep 8, 2017

@bors-servo retry

  • still the position-sticky tests
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

⚡ Previous build results for android, linux-dev, mac-dev-unit, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3...
@Manishearth
Copy link
Member Author

Manishearth commented Sep 8, 2017 •
edited

@mrobinson can we disable or fix the position-sticky tests? They've been causing intermittents all week.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 2b73735 to master...
@bors-servo bors-servo merged commit 489bbb8 into servo:master Sep 8, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 8, 2017
Merged
@Manishearth Manishearth deleted the Manishearth:bump-au branch Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Manishearth @highfive @jdm @bors-servo @wafflespeanut
You can’t perform that action at this time.