Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of AnimationValue code #18414

Merged
merged 3 commits into from Oct 3, 2017
Merged

Reduce the size of AnimationValue code #18414

merged 3 commits into from Oct 3, 2017
+42 −29

Conversation

@jdm
Copy link
Member

jdm commented Sep 7, 2017 •
edited

According to bloaty, these commits shave off 25k from code in the animated_properties module.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable
@highfive
Copy link

highfive commented Sep 7, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/helpers/animated_properties.mako.rs
  • @canaltinova: components/style/properties/helpers/animated_properties.mako.rs
  • @emilio: components/style/properties/helpers/animated_properties.mako.rs
@highfive
Copy link

highfive commented Sep 7, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Sep 7, 2017

r? @emilio
@highfive highfive assigned emilio and unassigned asajeffrey Sep 7, 2017
@SimonSapin
Copy link
Member

SimonSapin commented Sep 7, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

📌 Commit 626a126 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned emilio Sep 7, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

⌛ Testing commit 626a126 with merge 0b3c64e...
bors-servo added a commit that referenced this pull request Sep 7, 2017
@bors-servo
Auto merge of #18414 - jdm:animdecl-codesize, r=SimonSapin
Loading status checks…
0b3c64e 
Reduce the size of AnimationValue code

According to bloaty, these commits shave off 25k from code in the animated_properties module.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

💔 Test failed - windows-msvc-dev
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2017

☔ The latest upstream changes (presumably #18459) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm jdm force-pushed the jdm:animdecl-codesize branch from 626a126 to e6d10a2 Sep 14, 2017
@jdm
Copy link
Member Author

jdm commented Sep 14, 2017

@bors-servo: r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2017

📌 Commit e6d10a2 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2017

⌛ Testing commit e6d10a2 with merge 6be1fb8...
bors-servo added a commit that referenced this pull request Sep 14, 2017
@bors-servo
Auto merge of #18414 - jdm:animdecl-codesize, r=SimonSapin
Loading status checks…
6be1fb8 
Reduce the size of AnimationValue code

According to bloaty, these commits shave off 25k from code in the animated_properties module.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18414)
<!-- Reviewable:end -->
@jdm jdm force-pushed the jdm:animdecl-codesize branch from cf1d222 to cbff664 Sep 27, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2017

☔ The latest upstream changes (presumably #18692) made this pull request unmergeable. Please resolve the merge conflicts.
jdm added 3 commits Sep 7, 2017
@jdm
Remove 10k from AnimationValue::from_declaration.
13df088
@jdm
Remove 10k from AnimationValue::animate.
7990147
@jdm
Remove 5k from AnimationValue::compute_squared_distance.
Loading status checks…
01c35f9
@jdm jdm force-pushed the jdm:animdecl-codesize branch from cbff664 to 01c35f9 Oct 3, 2017
@jdm
Copy link
Member Author

jdm commented Oct 3, 2017

@bors-servo: r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit 01c35f9 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit 01c35f9 with merge b3148b9...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18414 - jdm:animdecl-codesize, r=SimonSapin
Loading status checks…
b3148b9 
Reduce the size of AnimationValue code

According to bloaty, these commits shave off 25k from code in the animated_properties module.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - linux-rel-css
@jdm
Copy link
Member Author

jdm commented Oct 3, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit 01c35f9 with merge eff7686...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18414 - jdm:animdecl-codesize, r=SimonSapin
Loading status checks…
eff7686 
Reduce the size of AnimationValue code

According to bloaty, these commits shave off 25k from code in the animated_properties module.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing eff7686 to master...
@bors-servo bors-servo merged commit 01c35f9 into servo:master Oct 3, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @highfive @SimonSapin @bors-servo @asajeffrey @emilio
You can’t perform that action at this time.