Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate mach.bat if use VS buildtool for Windows build #18421
Merged
Conversation
highfive
commented
Sep 8, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
README.md
Outdated
| > 3. Run `mach.bat build -d`. | ||
| >If you have troubles with `x64 type` prompt as `mach.bat` set by default: | ||
| > 1. you may need to choose and luanch the type manually, such as `x86_x64 Cross Tools Command Prompt for VS 2017` in the Windows menu.) |
This comment has been minimized.
This comment has been minimized.
|
Thanks - this is awesome! Once you address the typo in the readme, r=me. |
|
@larsbergstrom Done. Please check. Thanks :) |
|
@bors-servo r+ Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 9, 2017
update mach.bat if use VS buildtool for Windows build <!-- Please describe your changes on the following line: --> Add path in `mach.bat`. If user only install VS buildtool, they now can use `mach.bat` And therefore modify `README` Continue to PR #18145 r? @larsbergstrom --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18421) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tigercosmos commentedSep 8, 2017
•
edited by SimonSapin
Add path in
mach.bat. If user only install VS buildtool, they now can usemach.batAnd therefore modify
READMEContinue to PR #18145
r? @larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is