Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Remove stale todo about handling scrollbars in viewport units. #18422

Merged
merged 1 commit into from Sep 9, 2017
Merged

style: Remove stale todo about handling scrollbars in viewport units. #18422

merged 1 commit into from Sep 9, 2017

Conversation

@emilio
Copy link
Member

emilio commented Sep 8, 2017 •
edited by SimonSapin

This is effectively not going to happen, per
w3c/csswg-drafts#1766

This change is Reviewable
@emilio
style: Remove stale todo about handling scrollbars in viewport units.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
9a55b1e 
This is effectively not going to happen, per
w3c/csswg-drafts#1766
@highfive
Copy link

highfive commented Sep 8, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/media_queries.rs
  • @canaltinova: components/style/gecko/media_queries.rs
@highfive
Copy link

highfive commented Sep 8, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Sep 8, 2017

r? @Manishearth (or anyone else)
@highfive highfive assigned Manishearth and unassigned nox Sep 8, 2017
@bholley
Copy link
Contributor

bholley commented Sep 8, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

📌 Commit 9a55b1e has been approved by bholley
@highfive highfive assigned bholley and unassigned Manishearth Sep 8, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

⌛ Testing commit 9a55b1e with merge 9c0abfe...
bors-servo added a commit that referenced this pull request Sep 8, 2017
@bors-servo
Auto merge of #18422 - emilio:stale-todo, r=bholley
Loading status checks…
9c0abfe 
style: Remove stale todo about handling scrollbars in viewport units.

This is effectively not going to happen, per
w3c/csswg-drafts#1766

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18422)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 9, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: bholley
Pushing 9c0abfe to master...
@bors-servo bors-servo merged commit 9a55b1e into servo:master Sep 9, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@emilio emilio deleted the emilio:stale-todo branch Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@emilio @highfive @bholley @bors-servo @jdm @nox @Manishearth
You can’t perform that action at this time.