Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Remove a few uses of ComputedValueAsSpecified. #18429

Merged
merged 19 commits into from Sep 11, 2017
Merged

style: Remove a few uses of ComputedValueAsSpecified. #18429

merged 19 commits into from Sep 11, 2017

Conversation

@emilio
Copy link
Member

emilio commented Sep 9, 2017 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Sep 9, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/gecko.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/properties/longhand/position.mako.rs, components/style/values/computed/align.rs and 15 more
  • @canaltinova: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/gecko.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/properties/longhand/position.mako.rs, components/style/values/computed/align.rs and 15 more
@highfive
Copy link

highfive commented Sep 9, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Sep 9, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2017

⌛ Trying commit f34a43f with merge 64ee734...
bors-servo added a commit that referenced this pull request Sep 9, 2017
@bors-servo
Auto merge of #18429 - emilio:cvas-die, r=<try>
Loading status checks…
64ee734 
style: Remove a few uses of ComputedValueAsSpecified.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18429)
<!-- Reviewable:end -->
@emilio emilio force-pushed the emilio:cvas-die branch 2 times, most recently from 69b8899 to af9f757 Sep 9, 2017
@emilio
Copy link
Member Author

emilio commented Sep 9, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2017

⌛ Trying commit af9f757 with merge d4e570a...
bors-servo added a commit that referenced this pull request Sep 9, 2017
@bors-servo
Auto merge of #18429 - emilio:cvas-die, r=<try>
Loading status checks…
d4e570a 
style: Remove a few uses of ComputedValueAsSpecified.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18429)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2017

💔 Test failed - linux-rel-wpt
@emilio emilio force-pushed the emilio:cvas-die branch from af9f757 to e314927 Sep 9, 2017
@highfive highfive removed the S-tests-failed label Sep 9, 2017
@emilio
Copy link
Member Author

emilio commented Sep 9, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2017

⌛ Trying commit e314927 with merge b1b9188...
bors-servo added a commit that referenced this pull request Sep 9, 2017
@bors-servo
Auto merge of #18429 - emilio:cvas-die, r=<try>
Loading status checks…
b1b9188 
style: Remove a few uses of ComputedValueAsSpecified.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18429)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2017

💔 Test failed - linux-dev
@emilio emilio force-pushed the emilio:cvas-die branch from e314927 to 67d8e22 Sep 9, 2017
@highfive highfive removed the S-tests-failed label Sep 9, 2017
@emilio
Copy link
Member Author

emilio commented Sep 9, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2017

⌛ Trying commit 67d8e22 with merge fa17fcb...
bors-servo added a commit that referenced this pull request Sep 9, 2017
@bors-servo
Auto merge of #18429 - emilio:cvas-die, r=<try>
Loading status checks…
fa17fcb 
style: Remove a few uses of ComputedValueAsSpecified.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18429)
<!-- Reviewable:end -->
@emilio
Copy link
Member Author

emilio commented Sep 9, 2017

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80cd30910c4201c469009082ad75a1f6b44214a3
@emilio
Copy link
Member Author

emilio commented Sep 9, 2017

r? @nox
@highfive highfive assigned nox and unassigned KiChjang Sep 9, 2017
emilio added 17 commits Sep 9, 2017
@emilio
style: Derive ToComputedValue for keyword types.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
c87b485
@emilio
style: Derive ToComputedValue for font-variant-caps.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
9788ffe
@emilio
style: Remove the special-case in single_keyword_computed.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
900eaec 
The other case is pretty much the same.
@emilio
style: Use derive(TCV) in GeometryBox.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
156b371
@emilio
style: Use derive for -x-span.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
b9f5388
@emilio
style: Derive ToComputedValue in grid properties.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
5b05aa7
@emilio
style: Avoid ComputedValueAsSpecified in template-areas.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
84f3073 
Would need to impl ToComputedValue for Range and Box, which is undoable right
now.
@emilio
style: Derive ToComputedValue for TransitionProperty.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
b94dd48
@emilio
style: Unify the trivial ToComputedValue implementations, and add imp…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
a4da222 
…ls for i32.
@emilio
style: Get rid of ComputedValueAsSpecified in box.mako.rs.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
5e136a7
@emilio
style: Avoid ComputedValueAsSpecified for TrackKeyword.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
02d2406
@emilio
style: Properly use integers on grid properties, and derive ToCompute…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
64ab73e 
…dValue.
@emilio
style: Get rid of ComputedValueAsSpecified for alignment props.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
4c283fb
@emilio
style: Get rid of a few ComputedValueAsSpecified in grid.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
a3bfa5d 
Need Box to remove the macro invocation.
@emilio
style: Get rid of ComputedValueAsSpecified in inherited_text.rs
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
d1a3cb6
@emilio
style: Kill CVAS in image.rs.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
b12a34e
@emilio
style: Kill a few more CVAS uses in font.mako.rs.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
ba5897a
@emilio emilio force-pushed the emilio:cvas-die branch from 469d9c9 to ba5897a Sep 11, 2017
@emilio
Copy link
Member Author

emilio commented Sep 11, 2017

@bors-servo r=nox p=1
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2017

📌 Commit ba5897a has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2017

⌛ Testing commit ba5897a with merge 7fc2c43...
bors-servo added a commit that referenced this pull request Sep 11, 2017
@bors-servo
Auto merge of #18429 - emilio:cvas-die, r=nox
Loading status checks…
7fc2c43 
style: Remove a few uses of ComputedValueAsSpecified.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18429)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 7fc2c43 to master...
@bors-servo bors-servo merged commit ba5897a into servo:master Sep 11, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 11, 2017
Merged
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @nox @KiChjang
You can’t perform that action at this time.