[Do not merge] Rustc bisect #18445

SimonSapin · 2017-09-11T11:49:08Z

I could not reproduce locally the assertions failures in #18420, so I’ll try bisecting compiler versions on try CI.

This change is


        [Do not merge] Rustc bisect

SimonSapin · 2017-09-11T11:49:15Z

@bors-servo try


        Auto merge of #18445 - servo:rustup-bisect, r=<try>

[Do not merge] Rustc bisect I could not reproduce locally the assertions failures in #18420, so I’ll try bisecting compiler versions on try CI.

bors-servo · 2017-09-11T11:49:20Z

⌛ Trying commit 9bcc7d2 with merge c895049...

bors-servo · 2017-09-11T12:27:30Z

💔 Test failed - linux-rel-wpt


        Bisect

SimonSapin · 2017-09-11T12:57:22Z

  ▶ FAIL [expected PASS] /_mozilla/css/css-position-3/position-sticky-table-th-right.html
  └   → /_mozilla/css/css-position-3/position-sticky-table-th-right.html e9b9d42d83d50f68d193d258f7b8e977d06a08b7
/_mozilla/css/css-position-3/position-sticky-table-th-right-ref.html 8a37208e44c1426c46cd704a1051120fa696710f
Testing e9b9d42d83d50f68d193d258f7b8e977d06a08b7 == 8a37208e44c1426c46cd704a1051120fa696710f

Looks like assertion failed: distance_to_stack_bottom <= max_allowable_distance did not occur with Nightly 2017-09-04.

Trying 2017-09-06 now:

@bors-servo try

bors-servo · 2017-09-11T12:57:26Z

⌛ Trying commit 29a028d with merge ce32027...


        Auto merge of #18445 - servo:rustup-bisect, r=<try>

[Do not merge] Rustc bisect I could not reproduce locally the assertions failures in #18420, so I’ll try bisecting compiler versions on try CI.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18445)

bors-servo · 2017-09-11T14:10:20Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True


        Bisect

SimonSapin · 2017-09-11T14:44:08Z

@bors-servo try

bors-servo · 2017-09-11T14:44:13Z

⌛ Trying commit 9f9648f with merge 0e9f67c...


        Auto merge of #18445 - servo:rustup-bisect, r=<try>

[Do not merge] Rustc bisect I could not reproduce locally the assertions failures in #18420, so I’ll try bisecting compiler versions on try CI.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18445)

bors-servo · 2017-09-11T15:59:51Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True


        Bisect

SimonSapin · 2017-09-11T16:13:42Z

2017-09-06 and 2017-09-07 are "good" (did not produce that assertion failure in one try run each) too. Trying 2017-09-08 now, same as in #18420.

@bors-servo try

bors-servo · 2017-09-11T16:13:47Z

⌛ Trying commit c5e6869 with merge 544a022...


        Auto merge of #18445 - servo:rustup-bisect, r=<try>

[Do not merge] Rustc bisect I could not reproduce locally the assertions failures in #18420, so I’ll try bisecting compiler versions on try CI.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18445)

bors-servo · 2017-09-11T16:48:57Z

💔 Test failed - linux-rel-wpt


        Revert "Bisect"

This reverts commit c5e6869.

SimonSapin · 2017-09-11T17:43:02Z

assertion failed: distance_to_stack_bottom <= max_allowable_distance spotted on 2017-09-08. Trying 2017-09-07 again in case the previous run was a coincidence.

@bors-servo try

bors-servo · 2017-09-11T17:43:08Z

⌛ Trying commit e738503 with merge 7bce39b...


        Auto merge of #18445 - servo:rustup-bisect, r=<try>

[Do not merge] Rustc bisect I could not reproduce locally the assertions failures in #18420, so I’ll try bisecting compiler versions on try CI.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18445)

bors-servo · 2017-09-11T18:53:44Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

SimonSapin · 2017-09-11T18:57:31Z

Alright, I think it’s fairly safe to say that something in rust-lang/rust@3681220...d93036a is causing this assertions to be triggered.


        Bisect

SimonSapin · 2017-09-11T19:06:30Z

Now with some mach hacking to use per-PR builds from Rust CI instead of Nightly.

@bors-servo try

bors-servo · 2017-09-11T19:06:34Z

⌛ Trying commit 043474e with merge 536f788...


        Auto merge of #18445 - servo:rustup-bisect, r=<try>

[Do not merge] Rustc bisect I could not reproduce locally the assertions failures in #18420, so I’ll try bisecting compiler versions on try CI.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18445)

bors-servo · 2017-09-11T19:25:59Z

💔 Test failed - linux-dev


        Bisect

SimonSapin · 2017-09-11T20:27:22Z

Tidy is unhappy, but other jobs look green enough to call rust-lang/rust@05e3c96 "good".

Trying rust-lang/rust@d7d75ef now:

@bors-servo try

bors-servo · 2017-09-11T20:27:28Z

⌛ Trying commit b5fd42a with merge 2dea6c0...


        Auto merge of #18445 - servo:rustup-bisect, r=<try>

[Do not merge] Rustc bisect I could not reproduce locally the assertions failures in #18420, so I’ll try bisecting compiler versions on try CI.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18445)

bors-servo · 2017-09-11T21:00:39Z

💔 Test failed - linux-rel-wpt

jdm · 2017-09-11T21:35:59Z

ERROR:servo: assertion failed: distance_to_stack_bottom <= max_allowable_distance


        Bisect

SimonSapin · 2017-09-12T05:12:29Z

Thanks Josh. Trying rust-lang/rust@a6a9d4c, last run to reduce this to a single Rust PR.

@bors-servo try

SimonSapin · 2017-09-12T05:24:49Z

Oops, it works better if I don’t forget git push.

@bors-servo try

bors-servo · 2017-09-12T05:24:54Z

⌛ Trying commit cd98775 with merge 038f219...


        Auto merge of #18445 - servo:rustup-bisect, r=<try>

[Do not merge] Rustc bisect I could not reproduce locally the assertions failures in #18420, so I’ll try bisecting compiler versions on try CI.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18445)

SimonSapin · 2017-09-12T07:43:19Z

Looks like homu didn’t get the memo, but buildbot jobs are all green. This leaves rust-lang/rust#43931 as responsible (though possibly indirectly).

[Do not merge] Rustc bisect

Loading status checks…

9bcc7d2

highfive added the S-tests-failed label Sep 11, 2017

Bisect

Loading status checks…

29a028d

highfive added S-awaiting-review and removed S-tests-failed labels Sep 11, 2017

Bisect

Loading status checks…

9f9648f

Bisect

Loading status checks…

c5e6869

highfive added the S-tests-failed label Sep 11, 2017

Revert "Bisect"

Loading status checks…

e738503

This reverts commit c5e6869.

highfive removed the S-tests-failed label Sep 11, 2017

Bisect

Loading status checks…

043474e

highfive added the S-tests-failed label Sep 11, 2017

Bisect

Loading status checks…

b5fd42a

highfive removed the S-tests-failed label Sep 11, 2017

highfive added the S-tests-failed label Sep 11, 2017

Bisect

Loading status checks…

cd98775

highfive removed the S-tests-failed label Sep 12, 2017

SimonSapin closed this Sep 12, 2017

SimonSapin deleted the rustup-bisect branch Sep 12, 2017

SimonSapin mentioned this pull request Sep 12, 2017

Get rustc commit hash from channel manifest #18420

Merged

servo / servo

[Do not merge] Rustc bisect #18445

[Do not merge] Rustc bisect #18445

SimonSapin commented Sep 11, 2017 •

edited

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

jdm commented Sep 11, 2017

SimonSapin commented Sep 12, 2017 •

edited

SimonSapin commented Sep 12, 2017

bors-servo commented Sep 12, 2017

SimonSapin commented Sep 12, 2017

servo / servo

Join GitHub today

[Do not merge] Rustc bisect #18445

[Do not merge] Rustc bisect #18445

Conversation

SimonSapin commented Sep 11, 2017 • edited

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

SimonSapin commented Sep 11, 2017

bors-servo commented Sep 11, 2017

bors-servo commented Sep 11, 2017

jdm commented Sep 11, 2017

SimonSapin commented Sep 12, 2017 • edited

SimonSapin commented Sep 12, 2017

bors-servo commented Sep 12, 2017

SimonSapin commented Sep 12, 2017

SimonSapin commented Sep 11, 2017 •

edited

SimonSapin commented Sep 12, 2017 •

edited