Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-cssparser to 0.20.2. #18446

Merged
merged 1 commit into from Sep 11, 2017
Merged

Conversation

@bzbarsky
Copy link
Contributor

bzbarsky commented Sep 11, 2017

This reduces memory consumption of list-valued properties in the common case of one entry in the list.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

This reduces memory consumption of list-valued properties in the common case of one entry in the list.
@highfive

This comment has been minimized.

Copy link

highfive commented Sep 11, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, ports/geckolib/Cargo.toml, components/selectors/Cargo.toml
  • @canaltinova: components/style/Cargo.toml
  • @KiChjang: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
  • @fitzgen: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
  • @emilio: components/style/Cargo.toml, ports/geckolib/Cargo.toml
@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented Sep 11, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 11, 2017

📌 Commit b2c5634 has been approved by SimonSapin

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 11, 2017

⌛️ Testing commit b2c5634 with merge 3cad8d4...

bors-servo added a commit that referenced this pull request Sep 11, 2017
Update rust-cssparser to 0.20.2.

This reduces memory consumption of list-valued properties in the common case of one entry in the list.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18446)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 11, 2017

💔 Test failed - mac-rel-wpt2

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Sep 11, 2017

I saw that same error on another PR; I suspect a problem with the builder.

@bzbarsky

This comment has been minimized.

Copy link
Contributor Author

bzbarsky commented Sep 11, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 11, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 11, 2017

@bors-servo bors-servo merged commit b2c5634 into servo:master Sep 11, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.