Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill ComputedValueAsSpecified 🔫 #18459

Merged
merged 5 commits into from Sep 12, 2017
Merged

Kill ComputedValueAsSpecified 🔫 #18459

merged 5 commits into from Sep 12, 2017

Conversation

@nox
Copy link
Member

nox commented Sep 12, 2017 •
edited by SimonSapin

This change is Reviewable
nox added 5 commits Sep 11, 2017
@nox
Do not use CVAS for FontSettings<T>
bf034a8
@nox
Do not use CVAS for the list-style-image property
8917891
@nox
Kill ComputedValueAsSpecified 🔫
4e64ccd
@nox
Implement ToComputedValue for Box<T>
7c31202
@nox
Derive ToComputedValue for Image<..>
Loading status checks…
95f2d93
@highfive
Copy link

highfive commented Sep 12, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/computed/length.rs, components/style/values/computed/mod.rs, components/style/properties/helpers.mako.rs, components/style/properties/longhand/font.mako.rs, components/style/properties/helpers/animated_properties.mako.rs and 3 more
  • @canaltinova: components/style/values/computed/length.rs, components/style/values/computed/mod.rs, components/style/properties/helpers.mako.rs, components/style/properties/longhand/font.mako.rs, components/style/properties/helpers/animated_properties.mako.rs and 3 more
  • @emilio: components/style/values/computed/length.rs, components/style/values/computed/mod.rs, components/style/properties/helpers.mako.rs, components/style/properties/longhand/font.mako.rs, components/style/properties/helpers/animated_properties.mako.rs and 3 more
@highfive
Copy link

highfive commented Sep 12, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Sep 12, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2017

📌 Commit 95f2d93 has been approved by emilio
@highfive highfive assigned emilio and unassigned cbrewster Sep 12, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2017

⌛ Testing commit 95f2d93 with merge b856f11...
bors-servo added a commit that referenced this pull request Sep 12, 2017
@bors-servo
Auto merge of #18459 - servo:kill-cvas, r=emilio
Loading status checks…
b856f11 
Kill ComputedValueAsSpecified 🔫

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18459)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing b856f11 to master...
@bors-servo bors-servo merged commit 95f2d93 into master Sep 12, 2017
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
dependency-ci Checking Dependencies
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 12, 2017
Merged
2 of 2 tasks complete
@SimonSapin SimonSapin deleted the kill-cvas branch Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @emilio @bors-servo @cbrewster
You can’t perform that action at this time.