Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: a couple DOM conversion fixes #18539

Merged
merged 3 commits into from Sep 17, 2017
Merged

script: a couple DOM conversion fixes #18539

merged 3 commits into from Sep 17, 2017

Conversation

@emilio
Copy link
Member

emilio commented Sep 17, 2017 •
edited by SimonSapin

Fixes #18535

This change is Reviewable
@highfive
Copy link

highfive commented Sep 17, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/conversions.rs, components/script/dom/bindings/utils.rs
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/conversions.rs, components/script/dom/bindings/utils.rs
@highfive
Copy link

highfive commented Sep 17, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Sep 17, 2017

r? @nox

@bors-servo try

  • Want to see if anything catches this. Will add tests otherwise.
@highfive highfive assigned nox and unassigned KiChjang Sep 17, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2017

⌛ Trying commit f38d7e2 with merge 2c277d5...
bors-servo added a commit that referenced this pull request Sep 17, 2017
@bors-servo
Auto merge of #18539 - emilio:dom-conversion-fixes, r=<try>
Loading status checks…
2c277d5 
script: a couple DOM conversion fixes

Fixes #18535
@emilio emilio mentioned this pull request Sep 17, 2017
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2017

💔 Test failed - linux-rel-wpt
@nox
Copy link
Member

nox commented Sep 17, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2017

📌 Commit f38d7e2 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-wpt3, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2017

💔 Test failed - linux-rel-wpt
emilio added 3 commits Sep 17, 2017
@emilio
script: Fix code generation for named getters.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
b29e56e 
Fixes part of #18535
@emilio
script: Add a comment about some conversion that looks fishy.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
5281fc1
@emilio
script: Properly throw when "this" is not an object in a generic call.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
91f238f
@emilio emilio force-pushed the emilio:dom-conversion-fixes branch from f38d7e2 to 91f238f Sep 17, 2017
@emilio
Copy link
Member Author

emilio commented Sep 17, 2017

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2017

📌 Commit 91f238f has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2017

⌛ Testing commit 91f238f with merge 6f97dd1...
bors-servo added a commit that referenced this pull request Sep 17, 2017
@bors-servo
Auto merge of #18539 - emilio:dom-conversion-fixes, r=nox
Loading status checks…
6f97dd1 
script: a couple DOM conversion fixes

Fixes #18535

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18539)
<!-- Reviewable:end -->
@emilio emilio mentioned this pull request Sep 17, 2017
Merged
bors-servo added a commit that referenced this pull request Sep 17, 2017
@bors-servo
Auto merge of #18543 - emilio:named-getter-int, r=<try>
Loading status checks…
0885967 
script: Fix integer-JSID handling in named getters.

On top of #18539, fixes #10686.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Sep 17, 2017
@bors-servo
Auto merge of #18543 - emilio:named-getter-int, r=<try>
Loading status checks…
9eb8308 
script: Fix integer-JSID handling in named getters.

On top of #18539, fixes #10686.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Sep 17, 2017
@bors-servo
Auto merge of #18543 - emilio:named-getter-int, r=<try>
Loading status checks…
1edf26c 
script: Fix integer-JSID handling in named getters.

On top of #18539, fixes #10686.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 6f97dd1 to master...
@bors-servo bors-servo merged commit 91f238f into servo:master Sep 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:dom-conversion-fixes branch Sep 17, 2017
bors-servo added a commit that referenced this pull request Sep 17, 2017
@bors-servo
Auto merge of #18543 - emilio:named-getter-int, r=<try>
Loading status checks…
23e339f 
script: Fix integer-JSID handling in named getters.

On top of #18539, fixes #10686.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Sep 18, 2017
@bors-servo
Auto merge of #18543 - emilio:named-getter-int, r=<try>
Loading status checks…
1690151 
script: Fix integer-JSID handling in named getters.

On top of #18539, fixes #10686.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Sep 18, 2017
@bors-servo
Auto merge of #18543 - emilio:named-getter-int, r=<try>
Loading status checks…
fc82fe3 
script: Fix integer-JSID handling in named getters.

On top of #18539, fixes #10686.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Sep 18, 2017
@bors-servo
Auto merge of #18543 - emilio:named-getter-int, r=nox
Loading status checks…
ba90e13 
script: Fix integer-JSID handling in named getters.

On top of #18539, fixes #10686.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @nox @KiChjang
You can’t perform that action at this time.