Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: a couple DOM conversion fixes #18539

Merged
merged 3 commits into from Sep 17, 2017
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

script: Fix code generation for named getters.

Fixes part of #18535
  • Loading branch information
emilio committed Sep 17, 2017
commit b29e56eefcf0710bec318781de9bce5aabb5348a
@@ -4938,8 +4938,6 @@ def getBody(self):
set += ("if RUST_JSID_IS_STRING(id) {\n" +
CGIndenter(CGProxyNamedSetter(self.descriptor)).define() +
" return (*opresult).succeed();\n" +
"} else {\n" +
" return false;\n" +
"}\n")
else:
set += ("if RUST_JSID_IS_STRING(id) {\n" +
@@ -4948,7 +4946,7 @@ def getBody(self):
" return (*opresult).failNoNamedSetter();\n"
" }\n"
"}\n")
set += "return proxyhandler::define_property(%s);" % ", ".join(a.name for a in self.args)
set += "return proxyhandler::define_property(%s);" % ", ".join(a.name for a in self.args)
return set

def definition_body(self):
@@ -1,6 +1,5 @@
[storage_setitem.html]
type: testharness
expected: TIMEOUT
[localStorage[\] = ""]
expected: FAIL
bug: https://github.com/servo/servo/issues/6564
@@ -14,6 +13,72 @@
bug: https://github.com/servo/servo/issues/6564

[localStorage["0"\]]
expected: TIMEOUT
expected: FAIL
bug: https://github.com/servo/servo/issues/10686

[localStorage["1"\]]
expected: FAIL

[localStorage["2"\]]
expected: FAIL

[localStorage["3"\]]
expected: FAIL

[localStorage["4"\]]
expected: FAIL

[localStorage["5"\]]
expected: FAIL

[localStorage["6"\]]
expected: FAIL

[localStorage["7"\]]
expected: FAIL

[localStorage["8"\]]
expected: FAIL

[localStorage["9"\]]
expected: FAIL

[sessionStorage[\] = ""]
expected: FAIL

[sessionStorage[\] = "�a"]
expected: FAIL

[sessionStorage[\] = "a�"]
expected: FAIL

[sessionStorage["0"\]]
expected: FAIL

[sessionStorage["1"\]]
expected: FAIL

[sessionStorage["2"\]]
expected: FAIL

[sessionStorage["3"\]]
expected: FAIL

[sessionStorage["4"\]]
expected: FAIL

[sessionStorage["5"\]]
expected: FAIL

[sessionStorage["6"\]]
expected: FAIL

[sessionStorage["7"\]]
expected: FAIL

[sessionStorage["8"\]]
expected: FAIL

[sessionStorage["9"\]]
expected: FAIL

@@ -5,4 +5,3 @@
[Untitled]
expected: FAIL


ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.