script: Fix integer-JSID handling in named getters. #18543

emilio · 2017-09-17T17:30:45Z

On top of #18539, fixes #10686.

This change is

highfive · 2017-09-17T17:30:50Z

Heads up! This PR modifies the following files:

@fitzgen: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/utils.rs, components/script/dom/bindings/conversions.rs
@KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/utils.rs, components/script/dom/bindings/conversions.rs

emilio · 2017-09-17T17:31:26Z

@bors-servo try

bors-servo · 2017-09-17T17:31:30Z

⌛ Trying commit 6061a97 with merge 0885967...


        Auto merge of #18543 - emilio:named-getter-int, r=<try>

script: Fix integer-JSID handling in named getters. On top of #18539, fixes #10686.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)

emilio · 2017-09-17T17:33:30Z

@bors-servo try

bors-servo · 2017-09-17T17:33:34Z

⌛ Trying commit 79bbecf with merge 9eb8308...


        Auto merge of #18543 - emilio:named-getter-int, r=<try>

script: Fix integer-JSID handling in named getters. On top of #18539, fixes #10686.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)

bors-servo · 2017-09-17T17:47:01Z

💔 Test failed - linux-dev

emilio · 2017-09-17T18:02:45Z

@bors-servo try

bors-servo · 2017-09-17T18:02:57Z

⌛ Trying commit 80dd31d with merge 1edf26c...


        Auto merge of #18543 - emilio:named-getter-int, r=<try>

script: Fix integer-JSID handling in named getters. On top of #18539, fixes #10686.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)

emilio · 2017-09-17T18:06:07Z

@bors-servo try

Just rebased

bors-servo · 2017-09-17T18:06:12Z

⌛ Trying commit 0ec42a8 with merge 23e339f...


        Auto merge of #18543 - emilio:named-getter-int, r=<try>

script: Fix integer-JSID handling in named getters. On top of #18539, fixes #10686.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)

KiChjang · 2017-09-17T18:26:23Z

Uh oh, looks like this fixes #18468 as well.

bors-servo · 2017-09-17T18:50:21Z

💔 Test failed - mac-rel-wpt1

emilio · 2017-09-18T04:59:26Z

Added another commit to properly implement https://heycam.github.io/webidl/#LegacyPlatformObjectGetOwnProperty.

@bors-servo try

r? @nox or @jdm

bors-servo · 2017-09-18T04:59:31Z

⌛ Trying commit acd863d with merge 1690151...


        Auto merge of #18543 - emilio:named-getter-int, r=<try>

script: Fix integer-JSID handling in named getters. On top of #18539, fixes #10686.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)

bors-servo · 2017-09-18T05:32:07Z

💔 Test failed - linux-rel-wpt


        script: Fix integer-JSID handling in named getters.

Fixes #10686


        script: remove unused function.


        script: Properly implement LegacyPlatformGetOwnProperty in WebIDL.

We were missing the "ignoreNamedProperties" bit, which my previous patch uncovers.

emilio · 2017-09-18T07:15:33Z

@bors-servo try

Horray for more passing tests :)

bors-servo · 2017-09-18T07:15:38Z

⌛ Trying commit 90fb284 with merge fc82fe3...


        Auto merge of #18543 - emilio:named-getter-int, r=<try>

script: Fix integer-JSID handling in named getters. On top of #18539, fixes #10686.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)

bors-servo · 2017-09-18T08:57:22Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

nox · 2017-09-18T10:06:56Z

@bors-servo r+

bors-servo · 2017-09-18T10:06:57Z

📌 Commit 90fb284 has been approved by nox

bors-servo · 2017-09-18T11:27:27Z

⌛ Testing commit 90fb284 with merge ba90e13...


        Auto merge of #18543 - emilio:named-getter-int, r=nox

script: Fix integer-JSID handling in named getters. On top of #18539, fixes #10686.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)

bors-servo · 2017-09-18T12:54:15Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing ba90e13 to master...

highfive assigned nox Sep 17, 2017

highfive added the S-awaiting-review label Sep 17, 2017

highfive added the S-tests-failed label Sep 17, 2017

emilio force-pushed the emilio:named-getter-int branch from 79bbecf to 80dd31d Sep 17, 2017

highfive removed the S-tests-failed label Sep 17, 2017

emilio force-pushed the emilio:named-getter-int branch from 80dd31d to 0ec42a8 Sep 17, 2017

highfive added the S-tests-failed label Sep 17, 2017

KiChjang mentioned this pull request Sep 17, 2017

Ak 18468 #18546

Closed

0 of 5 tasks complete

emilio force-pushed the emilio:named-getter-int branch from 0ec42a8 to 4a25997 Sep 18, 2017

highfive removed the S-tests-failed label Sep 18, 2017

emilio force-pushed the emilio:named-getter-int branch from 4a25997 to acd863d Sep 18, 2017

highfive added the S-tests-failed label Sep 18, 2017

emilio added 3 commits Sep 17, 2017

script: Fix integer-JSID handling in named getters.

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

f5d16fc

Fixes #10686

script: remove unused function.

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

6edefb8

emilio force-pushed the emilio:named-getter-int branch from acd863d to 90fb284 Sep 18, 2017

highfive removed the S-tests-failed label Sep 18, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Sep 18, 2017

bors-servo merged commit 90fb284 into servo:master Sep 18, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Sep 18, 2017

emilio deleted the emilio:named-getter-int branch Sep 18, 2017

servo / servo

script: Fix integer-JSID handling in named getters. #18543

script: Fix integer-JSID handling in named getters. #18543

emilio commented Sep 17, 2017 •

edited by SimonSapin

highfive commented Sep 17, 2017

emilio commented Sep 17, 2017

bors-servo commented Sep 17, 2017

emilio commented Sep 17, 2017

bors-servo commented Sep 17, 2017

bors-servo commented Sep 17, 2017

emilio commented Sep 17, 2017 •

edited

bors-servo commented Sep 17, 2017

emilio commented Sep 17, 2017

bors-servo commented Sep 17, 2017

KiChjang commented Sep 17, 2017

bors-servo commented Sep 17, 2017

emilio commented Sep 18, 2017

bors-servo commented Sep 18, 2017

bors-servo commented Sep 18, 2017

emilio commented Sep 18, 2017

bors-servo commented Sep 18, 2017

bors-servo commented Sep 18, 2017

nox commented Sep 18, 2017

bors-servo commented Sep 18, 2017

bors-servo commented Sep 18, 2017

bors-servo commented Sep 18, 2017

servo / servo

Join GitHub today

script: Fix integer-JSID handling in named getters. #18543

script: Fix integer-JSID handling in named getters. #18543

Conversation

emilio commented Sep 17, 2017 • edited by SimonSapin

highfive commented Sep 17, 2017

emilio commented Sep 17, 2017

bors-servo commented Sep 17, 2017

emilio commented Sep 17, 2017

bors-servo commented Sep 17, 2017

bors-servo commented Sep 17, 2017

emilio commented Sep 17, 2017 • edited

bors-servo commented Sep 17, 2017

emilio commented Sep 17, 2017

bors-servo commented Sep 17, 2017

KiChjang commented Sep 17, 2017

bors-servo commented Sep 17, 2017

emilio commented Sep 18, 2017

bors-servo commented Sep 18, 2017

bors-servo commented Sep 18, 2017

emilio commented Sep 18, 2017

bors-servo commented Sep 18, 2017

bors-servo commented Sep 18, 2017

nox commented Sep 18, 2017

bors-servo commented Sep 18, 2017

bors-servo commented Sep 18, 2017

bors-servo commented Sep 18, 2017

emilio commented Sep 17, 2017 •

edited by SimonSapin

emilio commented Sep 17, 2017 •

edited