Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array instead of linked list for -moz-border-*-colors #18574

Merged
merged 1 commit into from Sep 20, 2017
Merged

Use array instead of linked list for -moz-border-*-colors #18574

merged 1 commit into from Sep 20, 2017

Conversation

@upsuper
Copy link
Member

upsuper commented Sep 20, 2017 •
edited by SimonSapin

This is the Servo side change of bug 1400438. (take 2)

This change is Reviewable
@upsuper
Use array instead of linked list for -moz-border-*-colors
Loading status checks…
4c24ae8
@highfive
Copy link

highfive commented Sep 20, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs
  • @emilio: components/style/gecko/generated/bindings.rs, components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs
@highfive
Copy link

highfive commented Sep 20, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper
Copy link
Member Author

upsuper commented Sep 20, 2017

@bors-servo r=heycam p=1
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2017

📌 Commit 4c24ae8 has been approved by heycam
@highfive highfive assigned heycam and unassigned pcwalton Sep 20, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2017

⌛ Testing commit 4c24ae8 with merge f11adbd...
bors-servo added a commit that referenced this pull request Sep 20, 2017
@bors-servo
Auto merge of #18574 - upsuper:moz-border-colors-array, r=heycam
Loading status checks…
f11adbd 
Use array instead of linked list for -moz-border-*-colors

This is the Servo side change of [bug 1400438](https://bugzilla.mozilla.org/show_bug.cgi?id=1400438). (take 2)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18574)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2017

💔 Test failed - mac-rel-wpt3
@upsuper
Copy link
Member Author

upsuper commented Sep 20, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2017

⌛ Testing commit 4c24ae8 with merge b49fe47...
bors-servo added a commit that referenced this pull request Sep 20, 2017
@bors-servo
Auto merge of #18574 - upsuper:moz-border-colors-array, r=heycam
Loading status checks…
b49fe47 
Use array instead of linked list for -moz-border-*-colors

This is the Servo side change of [bug 1400438](https://bugzilla.mozilla.org/show_bug.cgi?id=1400438). (take 2)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18574)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing b49fe47 to master...
@bors-servo bors-servo merged commit 4c24ae8 into servo:master Sep 20, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper-forks:moz-border-colors-array branch Sep 20, 2017
@moz-servo-sync moz-servo-sync mentioned this pull request Sep 20, 2017
Merged
moz-servo-sync added a commit to moz-servo-sync/servo that referenced this pull request Sep 20, 2017
Gecko Backout @moz-servo-sync
Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard…
7bcd57d 
…. r=backout

Backs out servo#18574
bors-servo added a commit that referenced this pull request Sep 20, 2017
@bors-servo
Auto merge of #18577 - moz-servo-sync:gecko-backout, r=moz-servo-sync
Loading status checks…
eefd59e 
Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard. r=backout

Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard. r=backout

Backs out #18574

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18577)
<!-- Reviewable:end -->
avadacatavra added a commit to avadacatavra/servo that referenced this pull request Oct 17, 2017
Gecko Backout @avadacatavra
Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard…
b86993b 
…. r=backout

Backs out servo#18574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@upsuper @highfive @bors-servo @pcwalton @heycam
You can’t perform that action at this time.