Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple gecko backouts #18577

Merged
merged 1 commit into from Sep 20, 2017
Merged

Multiple gecko backouts #18577

merged 1 commit into from Sep 20, 2017
+102 −176

Conversation

@moz-servo-sync
Copy link
Contributor

moz-servo-sync commented Sep 20, 2017 •
edited

Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard. r=backout

Backs out #18574

This change is Reviewable

Backed out changeset e64e659c077d: servo PR #18809 and revendor for reftest failures, e.g. in layout/reftests/bugs/392435-1.html. r=backout on a CLOSED TREE

Backs out #18809

Backed out changeset 196206f129ef (bug 1403213) for referencing non-existing xpcom/rust/gtest/moz.build in xpcom/moz.build. r=backout on a CLOSED TREE

Backs out #18941
Gecko Backout @moz-servo-sync
Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard…
Loading status checks…
7bcd57d 
…. r=backout

Backs out #18574
@moz-servo-sync
Copy link
Contributor Author

moz-servo-sync commented Sep 20, 2017

@bors-servo r+ force p=9001 treeclosed=9000
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2017

📌 Commit 7bcd57d has been approved by moz-servo-sync
@highfive
Copy link

highfive commented Sep 20, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @cbrewster (or someone else) soon.
@highfive
Copy link

highfive commented Sep 20, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs
  • @emilio: components/style/gecko/generated/bindings.rs, components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs
@highfive
Copy link

highfive commented Sep 20, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Sep 20, 2017

@bors-servo treeclosed-

Homu is sitting on its hands.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2017

⌛ Testing commit 7bcd57d with merge eefd59e...
bors-servo added a commit that referenced this pull request Sep 20, 2017
@bors-servo
Auto merge of #18577 - moz-servo-sync:gecko-backout, r=moz-servo-sync
Loading status checks…
eefd59e 
Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard. r=backout

Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard. r=backout

Backs out #18574

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18577)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: moz-servo-sync
Pushing eefd59e to master...
@bors-servo bors-servo merged commit 7bcd57d into servo:master Sep 20, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@moz-servo-sync
Copy link
Contributor Author

moz-servo-sync commented Oct 19, 2017

@bors-servo r+ force p=9001 treeclosed=9000
@moz-servo-sync moz-servo-sync changed the title Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard. r=backout Multiple gecko backouts Oct 19, 2017
@moz-servo-sync
Copy link
Contributor Author

moz-servo-sync commented Oct 20, 2017

@bors-servo r+ force p=9001 treeclosed=9000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbrewster cbrewster

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@moz-servo-sync @bors-servo @highfive @nox @cbrewster
You can’t perform that action at this time.