Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWindow should own Location, Document shouldn't #18578
Merged
Conversation
highfive
commented
Sep 20, 2017
highfive
commented
Sep 20, 2017
|
|
|
@bors-servo r+ Looks good. |
|
|
components/script/dom/document.rs
Outdated
| @@ -3438,7 +3436,7 @@ impl DocumentMethods for Document { | |||
|
|
|||
| // https://html.spec.whatwg.org/multipage/#dom-document-location | |||
| fn GetLocation(&self) -> Option<Root<Location>> { | |||
| self.browsing_context().map(|_| self.location.or_init(|| Location::new(&self.window))) | |||
| self.browsing_context().map(|_| self.window.Location()) | |||
This comment has been minimized.
This comment has been minimized.
KiChjang
Sep 20, 2017
•
Member
I believe the document needs to be checked whether it's fully active, instead of checking whether there's a browsing context.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r- |
asajeffrey
force-pushed the
asajeffrey:script-window-owns-location
branch
from
211b008
to
3d00b0e
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 20, 2017
…jang Window should own Location, Document shouldn't <!-- Please describe your changes on the following line: --> Document shouldn't own location, Window should. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18438 - [X] These changes do not require tests because it's an intermittent <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18578) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedSep 20, 2017
•
edited by SimonSapin
Document shouldn't own location, Window should.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is