Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused feature gates #18579

Merged
merged 5 commits into from Sep 21, 2017
Merged

Remove unused feature gates #18579

merged 5 commits into from Sep 21, 2017
+13 −9

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 20, 2017 •
edited by SimonSapin

CC #5286.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because no code changes

This change is Reviewable
mbrubeck added 2 commits Sep 20, 2017
@mbrubeck
Remove unused 'start' feature flag
acf60be
@mbrubeck
Remove unnecessary 'stmt_expr_attributes' feature flag
Loading status checks…
9064907
@highfive
Copy link

highfive commented Sep 20, 2017

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Sep 20, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@mbrubeck mbrubeck force-pushed the mbrubeck:features branch from 401b72c to 9064907 Sep 20, 2017
mbrubeck added 2 commits Sep 20, 2017
@mbrubeck
Remove unused 'unboxed_closures' feature flag
Loading status checks…
f31c8e6
@mbrubeck
Stop using unstable 'unique' feature
Loading status checks…
2795e5f 
The `Unique` wrapper was only needed to provide the `Sync` trait.
@KiChjang
Copy link
Member

KiChjang commented Sep 21, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2017

📌 Commit f58e50e has been approved by KiChjang
@highfive highfive assigned KiChjang and unassigned asajeffrey Sep 21, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2017

⌛ Testing commit f58e50e with merge 3588af6...
bors-servo added a commit that referenced this pull request Sep 21, 2017
@bors-servo
Auto merge of #18579 - mbrubeck:features, r=KiChjang
Loading status checks…
3588af6 
Remove unused feature gates

CC #5286.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because no code changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18579)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2017

💔 Test failed - arm64
@mbrubeck
Split feature gates into lines for easy grepping
Loading status checks…
2f03096
@mbrubeck mbrubeck force-pushed the mbrubeck:features branch from f58e50e to 2f03096 Sep 21, 2017
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Sep 21, 2017

@bors-servo r=KiChjang

  • Reverted the alloc_jemalloc change that broke the ARM build.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2017

📌 Commit 2f03096 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2017

⌛ Testing commit 2f03096 with merge 29517d5...
bors-servo added a commit that referenced this pull request Sep 21, 2017
@bors-servo
Auto merge of #18579 - mbrubeck:features, r=KiChjang
Loading status checks…
29517d5 
Remove unused feature gates

CC #5286.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because no code changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18579)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: KiChjang
Pushing 29517d5 to master...
@bors-servo bors-servo merged commit 2f03096 into servo:master Sep 21, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mbrubeck @highfive @KiChjang @bors-servo @asajeffrey
You can’t perform that action at this time.