Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script iframe intial load replaces about blank #18587

Closed
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Don't send two mozbrowserlocationchange events when navigating with r…

…eplacement
  • Loading branch information
asajeffrey committed Sep 21, 2017
commit cad9d80b304b011810ad9795f722f5d25defd0e1
@@ -2504,7 +2504,10 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>

// If the navigation is for a top-level browsing context, inform mozbrowser
if change.browsing_context_id == change.top_level_browsing_context_id {
self.trigger_mozbrowserlocationchange(change.top_level_browsing_context_id);
// If this is a replacement then we've already triggered the event in traverse_to_entry

This comment has been minimized.

@cbrewster

cbrewster Sep 25, 2017

Member

Should we just return early when calling traverse_to_entry?

if change.replace_instant.is_none() {
self.trigger_mozbrowserlocationchange(change.top_level_browsing_context_id);
}
}

self.update_frame_tree_if_active(change.top_level_browsing_context_id);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.