Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script iframe intial load replaces about blank #18587

Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -2504,7 +2504,10 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>

// If the navigation is for a top-level browsing context, inform mozbrowser
if change.browsing_context_id == change.top_level_browsing_context_id {
self.trigger_mozbrowserlocationchange(change.top_level_browsing_context_id);
// If this is a replacement then we've already triggered the event in traverse_to_entry

This comment has been minimized.

@cbrewster

cbrewster Sep 25, 2017

Member

Should we just return early when calling traverse_to_entry?

if change.replace_instant.is_none() {
self.trigger_mozbrowserlocationchange(change.top_level_browsing_context_id);
}
}

self.update_frame_tree_if_active(change.top_level_browsing_context_id);
@@ -256,7 +256,8 @@ impl HTMLIFrameElement {

let document = document_from_node(self);
let load_data = LoadData::new(url, creator_pipeline_id, document.get_referrer_policy(), Some(document.url()));
self.navigate_or_reload_child_browsing_context(Some(load_data), NavigationType::Regular, false);
let replace = mode == ProcessingMode::FirstTime;
self.navigate_or_reload_child_browsing_context(Some(load_data), NavigationType::Regular, replace);
}

#[allow(unsafe_code)]
@@ -304,13 +305,6 @@ impl HTMLIFrameElement {

self.pipeline_id.set(Some(new_pipeline_id));

// Only terminate the load blocker if the pipeline id was updated due to a traversal.
// The load blocker will be terminated for a navigation in iframe_load_event_steps.
if reason == UpdatePipelineIdReason::Traversal {
let mut blocker = self.load_blocker.borrow_mut();
LoadBlocker::terminate(&mut blocker);
}

self.upcast::<Node>().dirty(NodeDamage::OtherNodeDamage);
let window = window_from_node(self);
window.reflow(ReflowGoal::ForDisplay,
@@ -1,6 +1,6 @@
[location-protocol-setter-non-broken.html]
type: testharness
expected: CRASH
expected: OK
[Set data URL frame location.protocol to x]
expected: FAIL

@@ -19,3 +19,18 @@
[Set data URL frame location.protocol to http+x]
expected: FAIL

[Set HTTP URL frame location.protocol to ftp]
expected: FAIL

[Set HTTP URL frame location.protocol to gopher]
expected: FAIL

[Set HTTP URL frame location.protocol to x]
expected: FAIL

[Set HTTP URL frame location.protocol to data]
expected: FAIL

[Set HTTP URL frame location.protocol to http+x]
expected: FAIL

This file was deleted.

@@ -1,6 +1,6 @@
[iframe_sandbox_allow_script.html]
type: testharness
expected: ERROR
expected: TIMEOUT
bug: https://github.com/servo/servo/issues/14368
[iframe_sandbox_allow_scripts]
expected: NOTRUN

This file was deleted.

This file was deleted.

This file was deleted.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.