Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Atom::from(nsIAtom) to increment reference count in case of dynam… #18590

Merged

Conversation

Projects
None yet
3 participants
@hiikezoe
Copy link
Contributor

commented Sep 21, 2017

…ic atom for will-change.

If we don't increment the reference count for the Atom in servo side, it's
possible to try to release the Atom in servo side even if we have already
released in gecko side. When it happens, nsIAtom::mKind is no longer reliable.

https://bugzilla.mozilla.org/show_bug.cgi?id=1401809


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable

Hiroyuki Ikezoe
Use Atom::from(nsIAtom) to increment reference count in case of dynam…
…ic atom for will-change.

If we don't increment the reference count for the Atom in servo side, it's
possible to try to release the Atom in servo side even if we have already
released in gecko side.  When it happens, nsIAtom::mKind is no longer reliable.
@hiikezoe

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2017

@bors-servo r=xidorn

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2017

📌 Commit dcd959f has been approved by xidorn

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2017

⌛️ Testing commit dcd959f with merge 5589dcf...

bors-servo added a commit that referenced this pull request Sep 21, 2017

Auto merge of #18590 - hiikezoe:increment-ref-count-for-will-change, …
…r=xidorn

Use Atom::from(nsIAtom) to increment reference count in case of dynam…

…ic atom for will-change.

If we don't increment the reference count for the Atom in servo side, it's
possible to try to release the Atom in servo side even if we have already
released in gecko side.  When it happens, nsIAtom::mKind is no longer reliable.

https://bugzilla.mozilla.org/show_bug.cgi?id=1401809

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18590)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2017

💔 Test failed - mac-rel-css2

@hiikezoe

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2017

command timed out: 1200 seconds without output running ['env', 'PKG_CONFIG_PATH=/usr/local/opt/zlib/lib/pkgconfig', './mach', 'build', '--release'], attempting to kill
process killed by signal 9

timed out? It's an infra issue or something?
@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2017

⌛️ Testing commit dcd959f with merge 581f0bf...

bors-servo added a commit that referenced this pull request Sep 21, 2017

Auto merge of #18590 - hiikezoe:increment-ref-count-for-will-change, …
…r=xidorn

Use Atom::from(nsIAtom) to increment reference count in case of dynam…

…ic atom for will-change.

If we don't increment the reference count for the Atom in servo side, it's
possible to try to release the Atom in servo side even if we have already
released in gecko side.  When it happens, nsIAtom::mKind is no longer reliable.

https://bugzilla.mozilla.org/show_bug.cgi?id=1401809

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18590)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2017

@bors-servo bors-servo merged commit dcd959f into servo:master Sep 21, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@hiikezoe hiikezoe deleted the hiikezoe:increment-ref-count-for-will-change branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.