Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to conform a bit more to "The event loop processing model" #18611

Closed
wants to merge 3 commits into from
Closed

Try to conform a bit more to "The event loop processing model" #18611

wants to merge 3 commits into from

Conversation

@nox
Copy link
Member

nox commented Sep 24, 2017 •
edited by SimonSapin

This change is Reviewable
@emilio @nox
Ensure that script animation callbacks are run after layout animations
f9f160f 
Per https://html.spec.whatwg.org/multipage/webappapis.html#run-css-animations-and-send-events
@highfive
Copy link

highfive commented Sep 24, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/constellation.rs
  • @paulrouget: components/compositing/compositor.rs, components/constellation/constellation.rs
  • @fitzgen: components/script/dom/document.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_layout_interface/message.rs, components/script_traits/lib.rs and 1 more
  • @KiChjang: components/script/dom/document.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_layout_interface/message.rs, components/script_traits/lib.rs and 1 more
@nox nox mentioned this pull request Sep 24, 2017
Closed
3 of 3 tasks complete
@nox
Copy link
Member Author

nox commented Sep 24, 2017

Cc @emilio
@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2017

⌛ Trying commit 1cbbf4a with merge 3827caa...
bors-servo added a commit that referenced this pull request Sep 24, 2017
@bors-servo
Auto merge of #18611 - servo:event-loop, r=<try>
Loading status checks…
3827caa 
Try to conform a bit more to "The event loop processing model"
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2017

💔 Test failed - android
emilio added 2 commits Oct 20, 2016
@emilio @nox
Make basic-transition.html deterministic and report better errors
1b8b0b6
@emilio @nox
Try to conform a bit more to "The event loop processing model"
Loading status checks…
75b7bf8 
This removes a set of hacks that we'd been piling up.
@nox nox force-pushed the event-loop branch from 1cbbf4a to 75b7bf8 Sep 24, 2017
@nox
Copy link
Member Author

nox commented Sep 24, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2017

⌛ Trying commit 75b7bf8 with merge 5d7fa35...
bors-servo added a commit that referenced this pull request Sep 24, 2017
@bors-servo
Auto merge of #18611 - servo:event-loop, r=<try>
Loading status checks…
5d7fa35 
Try to conform a bit more to "The event loop processing model"

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18611)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2017

💔 Test failed - linux-rel-css
@nox
Copy link
Member Author

nox commented Sep 24, 2017

Cc @emilio, was that already the case in your PR?

  ▶ TIMEOUT [expected PASS] /css-ui-3_dev/html/text-overflow-005.htm
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 17.2.0-devel
@emilio
Copy link
Member

emilio commented Sep 24, 2017

Not really, I can look into it if you can't. Thanks a lot for rebasing this @nox!
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

☔ The latest upstream changes (presumably #18924) made this pull request unmergeable. Please resolve the merge conflicts.
This was referenced Nov 15, 2017
Open
Open
@jdm
Copy link
Member

jdm commented Nov 15, 2017

Closing due to inactivity. Tracking in #19242.
@jdm jdm closed this Nov 15, 2017
@nox nox deleted the event-loop branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
S-awaiting-review S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @bors-servo @emilio @jdm @wafflespeanut
You can’t perform that action at this time.