script: Remove HTMLAppletElement. #18657

emilio · 2017-09-27T18:43:41Z

It was removed from the spec, there's no reason to keep it in tree.

This change is

emilio · 2017-09-27T18:44:10Z

r? @nox

@bors-servo try

I'm moderately sure this requires test expectation changes.

bors-servo · 2017-09-27T18:44:15Z

⌛ Trying commit 2dde343 with merge 8629651...


        Auto merge of #18657 - emilio:bye-applet, r=<try>

script: Remove HTMLAppletElement. It was removed from the spec, there's no reason to keep it in tree.

bors-servo · 2017-09-27T19:18:30Z

💔 Test failed - arm32

KiChjang · 2017-09-27T19:36:49Z

Needs a change in manifest, once that done you can r=me.

emilio · 2017-09-28T07:56:12Z

@bors-servo r=KiChjang

bors-servo · 2017-09-28T07:56:12Z

📌 Commit e30d4d4 has been approved by KiChjang

bors-servo · 2017-09-28T07:56:17Z

⌛ Testing commit e30d4d4 with merge 6f2d6cb...


        Auto merge of #18657 - emilio:bye-applet, r=KiChjang

script: Remove HTMLAppletElement. It was removed from the spec, there's no reason to keep it in tree.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18657)

bors-servo · 2017-09-28T08:29:07Z

💔 Test failed - mac-rel-wpt4

mbrubeck · 2017-10-03T20:23:13Z

  ▶ Unexpected subtest result in /_mozilla/mozilla/collections.html:
  │ FAIL [expected PASS] test_binding\n    page  
  │   → HTMLAppletElement is not defined

bors-servo · 2017-10-16T17:55:23Z

☔ The latest upstream changes (presumably #18900) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo · 2017-10-21T18:29:07Z

🔒 Merge conflict

emilio · 2017-11-05T16:26:32Z

@bors-servo r=KiChjang

jdm · 2017-11-06T03:33:56Z

  ▶ Unexpected subtest result in /html/dom/documents/dom-tree-accessors/nameditem-03.html:
  └ PASS [expected FAIL] applet elements are (mostly) gone

  ▶ Unexpected subtest result in /html/semantics/interfaces.html:
  └ PASS [expected FAIL] Interfaces for applet

  ▶ Unexpected subtest result in /html/semantics/interfaces.html:
  └ PASS [expected FAIL] Interfaces for APPLET

emilio · 2017-11-06T09:56:28Z

@bors-servo r=KiChjang

bors-servo · 2017-11-06T09:56:29Z

📌 Commit 54e15c8 has been approved by KiChjang

bors-servo · 2017-11-06T10:33:50Z

⌛ Testing commit 54e15c8 with merge 4729cb7...


        Auto merge of #18657 - emilio:bye-applet, r=KiChjang

script: Remove HTMLAppletElement. It was removed from the spec, there's no reason to keep it in tree.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18657)

bors-servo · 2017-11-06T11:13:49Z

💔 Test failed - linux-rel-wpt

jdm · 2017-11-06T12:46:36Z

  ▶ Unexpected subtest result in /html/dom/reflection-obsolete.html:
  │ FAIL [expected PASS] applet.name: IDL get with DOM attribute unset
  │   → assert_equals: expected (string) "" but got (undefined) undefined
  │ 
  │ ReflectionTests.reflects/<@http://web-platform.test:8000/html/dom/reflection.js:641:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
  │ test@http://web-platform.test:8000/resources/testharness.js:511:9
  │ ReflectionHarness.test@http://web-platform.test:8000/html/dom/new-harness.js:6:3
  │ ReflectionTests.reflects@http://web-platform.test:8000/html/dom/reflection.js:640:9
  └ @http://web-platform.test:8000/html/dom/reflection.js:908:9

  ▶ Unexpected subtest result in /html/dom/reflection-obsolete.html:
  │ FAIL [expected PASS] applet.name: setAttribute() to ""
  │   → assert_equals: IDL get expected (string) "" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f  foo "
  │   → assert_equals: IDL get expected (string) " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to undefined
  │   → assert_equals: IDL get expected (string) "undefined" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to 7
  │   → assert_equals: IDL get expected (string) "7" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to 1.5
  │   → assert_equals: IDL get expected (string) "1.5" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to true
  │   → assert_equals: IDL get expected (string) "true" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to false
  │   → assert_equals: IDL get expected (string) "false" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to object "[object Object]"
  │   → assert_equals: IDL get expected (string) "[object Object]" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to NaN
  │   → assert_equals: IDL get expected (string) "NaN" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to Infinity
  │   → assert_equals: IDL get expected (string) "Infinity" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to -Infinity
  │   → assert_equals: IDL get expected (string) "-Infinity" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to "\\0"
  │   → assert_equals: IDL get expected (string) "\0" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to null
  │   → assert_equals: IDL get expected (string) "null" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to object "test-toString"
  │   → assert_equals: IDL get expected (string) "test-toString" but got (undefined) undefined
  │ FAIL [expected PASS] applet.name: setAttribute() to object "test-valueOf"
  │   → assert_equals: IDL get expected (string) "test-valueOf" but got (undefined) undefined
  │ 
  │ ReflectionTests.reflects/<@http://web-platform.test:8000/html/dom/reflection.js:819:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
  │ test@http://web-platform.test:8000/resources/testharness.js:511:9
  │ ReflectionHarness.test@http://web-platform.test:8000/html/dom/new-harness.js:6:3
  │ ReflectionTests.reflects@http://web-platform.test:8000/html/dom/reflection.js:815:9
  └ @http://web-platform.test:8000/html/dom/reflection.js:908:9

  ▶ Unexpected subtest result in /html/dom/reflection-obsolete.html:
  │ FAIL [expected PASS] applet.name: IDL set to ""
  │   → assert_equals: getAttribute() expected "" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f  foo "
  │   → assert_equals: getAttribute() expected " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to undefined
  │   → assert_equals: getAttribute() expected "undefined" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to 7
  │   → assert_equals: getAttribute() expected "7" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to 1.5
  │   → assert_equals: getAttribute() expected "1.5" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to true
  │   → assert_equals: getAttribute() expected "true" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to false
  │   → assert_equals: getAttribute() expected "false" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to object "[object Object]"
  │   → assert_equals: getAttribute() expected "[object Object]" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to NaN
  │   → assert_equals: getAttribute() expected "NaN" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to Infinity
  │   → assert_equals: getAttribute() expected "Infinity" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to -Infinity
  │   → assert_equals: getAttribute() expected "-Infinity" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to "\\0"
  │   → assert_equals: getAttribute() expected "\0" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to null
  │   → assert_equals: getAttribute() expected "null" but got "test-valueOf"
  │ FAIL [expected PASS] applet.name: IDL set to object "test-toString"
  │   → assert_equals: getAttribute() expected "test-toString" but got "test-valueOf"
  │ 
  │ ReflectionTests.reflects/<@http://web-platform.test:8000/html/dom/reflection.js:842:21
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
  │ test@http://web-platform.test:8000/resources/testharness.js:511:9
  │ ReflectionHarness.test@http://web-platform.test:8000/html/dom/new-harness.js:6:3
  │ ReflectionTests.reflects@http://web-platform.test:8000/html/dom/reflection.js:825:9
  └ @http://web-platform.test:8000/html/dom/reflection.js:908:9

  ▶ Unexpected subtest result in /html/dom/reflection-obsolete.html:
  │ FAIL [expected PASS] applet.name: typeof IDL attribute
  │   → assert_equals: expected "string" but got "undefined"
  │ 
  │ ReflectionTests.reflects/<@http://web-platform.test:8000/html/dom/reflection.js:620:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
  │ test@http://web-platform.test:8000/resources/testharness.js:511:9
  │ ReflectionHarness.test@http://web-platform.test:8000/html/dom/new-harness.js:6:3
  │ ReflectionTests.reflects@http://web-platform.test:8000/html/dom/reflection.js:619:5
  └ @http://web-platform.test:8000/html/dom/reflection.js:908:9

  ▶ Unexpected subtest result in /html/dom/reflection-obsolete.html:
  │ FAIL [expected PASS] applet.name: IDL set to object "test-valueOf"
  │   → assert_equals: IDL get expected (string) "test-valueOf" but got (object) object "test-valueOf"
  │ 
  │ ReflectionTests.reflects/<@http://web-platform.test:8000/html/dom/reflection.js:846:21
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
  │ test@http://web-platform.test:8000/resources/testharness.js:511:9
  │ ReflectionHarness.test@http://web-platform.test:8000/html/dom/new-harness.js:6:3
  │ ReflectionTests.reflects@http://web-platform.test:8000/html/dom/reflection.js:825:9
  └ @http://web-platform.test:8000/html/dom/reflection.js:908:9

emilio · 2017-11-06T15:55:21Z

So, a couple of those are defined in HTMLElement in Gecko. Should I just update the expectations for now @jdm?

emilio · 2017-11-06T15:56:26Z

Err, applet.name also fails in Gecko, I lie...


        script: Remove HTMLAppletElement.

It was removed from the spec, there's no reason to keep it in tree.

emilio · 2017-11-06T16:10:27Z

@bors-servo r=KiChjang

bors-servo · 2017-11-06T16:10:28Z

📌 Commit 8b0f58c has been approved by KiChjang

bors-servo · 2017-11-06T16:46:46Z

⌛ Testing commit 8b0f58c with merge a509ebf...


        Auto merge of #18657 - emilio:bye-applet, r=KiChjang

script: Remove HTMLAppletElement. It was removed from the spec, there's no reason to keep it in tree.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18657)

bors-servo · 2017-11-06T18:30:50Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: KiChjang
Pushing a509ebf to master...

highfive assigned nox Sep 27, 2017

bors-servo added a commit that referenced this pull request Sep 27, 2017

Auto merge of #18657 - emilio:bye-applet, r=<try>

Loading status checks…

8629651

script: Remove HTMLAppletElement. It was removed from the spec, there's no reason to keep it in tree.

highfive added the S-tests-failed label Sep 27, 2017

emilio force-pushed the emilio:bye-applet branch from 2dde343 to e30d4d4 Sep 28, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Sep 28, 2017

highfive unassigned nox Sep 28, 2017

highfive removed the S-awaiting-review label Sep 28, 2017

highfive assigned KiChjang Sep 28, 2017

highfive added the S-awaiting-merge label Sep 28, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 28, 2017

highfive added the S-needs-rebase label Oct 16, 2017

emilio force-pushed the emilio:bye-applet branch from e30d4d4 to a170f2e Nov 5, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Nov 5, 2017

emilio force-pushed the emilio:bye-applet branch from a170f2e to cdffbeb Nov 5, 2017

highfive added the S-tests-failed label Nov 5, 2017

emilio force-pushed the emilio:bye-applet branch from 7fadc5c to 54e15c8 Nov 6, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Nov 6, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 6, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 6, 2017

script: Remove HTMLAppletElement.

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

Loading status checks…

8b0f58c

It was removed from the spec, there's no reason to keep it in tree.

emilio force-pushed the emilio:bye-applet branch from 54e15c8 to 8b0f58c Nov 6, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Nov 6, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 6, 2017

bors-servo merged commit 8b0f58c into servo:master Nov 6, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Nov 6, 2017

servo / servo

script: Remove HTMLAppletElement. #18657

script: Remove HTMLAppletElement. #18657

emilio commented Sep 27, 2017 •

edited by SimonSapin

emilio commented Sep 27, 2017

bors-servo commented Sep 27, 2017

bors-servo commented Sep 27, 2017

KiChjang commented Sep 27, 2017

emilio commented Sep 28, 2017

bors-servo commented Sep 28, 2017

bors-servo commented Sep 28, 2017

bors-servo commented Sep 28, 2017

mbrubeck commented Oct 3, 2017

bors-servo commented Oct 16, 2017

bors-servo commented Oct 21, 2017

emilio commented Nov 5, 2017

jdm commented Nov 6, 2017

emilio commented Nov 6, 2017

bors-servo commented Nov 6, 2017

bors-servo commented Nov 6, 2017

bors-servo commented Nov 6, 2017

jdm commented Nov 6, 2017

emilio commented Nov 6, 2017

emilio commented Nov 6, 2017

emilio commented Nov 6, 2017

bors-servo commented Nov 6, 2017

bors-servo commented Nov 6, 2017

bors-servo commented Nov 6, 2017

servo / servo

Join GitHub today

script: Remove HTMLAppletElement. #18657

script: Remove HTMLAppletElement. #18657

Conversation

emilio commented Sep 27, 2017 • edited by SimonSapin

emilio commented Sep 27, 2017

bors-servo commented Sep 27, 2017

bors-servo commented Sep 27, 2017

KiChjang commented Sep 27, 2017

emilio commented Sep 28, 2017

bors-servo commented Sep 28, 2017

bors-servo commented Sep 28, 2017

bors-servo commented Sep 28, 2017

mbrubeck commented Oct 3, 2017

bors-servo commented Oct 16, 2017

bors-servo commented Oct 21, 2017

emilio commented Nov 5, 2017

jdm commented Nov 6, 2017

emilio commented Nov 6, 2017

bors-servo commented Nov 6, 2017

bors-servo commented Nov 6, 2017

bors-servo commented Nov 6, 2017

jdm commented Nov 6, 2017

emilio commented Nov 6, 2017

emilio commented Nov 6, 2017

emilio commented Nov 6, 2017

bors-servo commented Nov 6, 2017

bors-servo commented Nov 6, 2017

bors-servo commented Nov 6, 2017

emilio commented Sep 27, 2017 •

edited by SimonSapin