Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (reduce GPU allocations for render targets) #18669

Merged
merged 1 commit into from Oct 3, 2017
Merged

Update WR (reduce GPU allocations for render targets) #18669

merged 1 commit into from Oct 3, 2017
+2 −2

Conversation

@glennw
Copy link
Member

glennw commented Sep 28, 2017 •
edited by SimonSapin

This change is Reviewable
@glennw
Copy link
Member Author

glennw commented Sep 28, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2017

⌛ Trying commit 02d096e with merge b1323c7...
bors-servo added a commit that referenced this pull request Sep 28, 2017
@bors-servo
Auto merge of #18669 - glennw:update-wr-memory, r=<try>
Loading status checks…
b1323c7 
Update WR (reduce GPU allocations for render targets)
@jdm
Copy link
Member

jdm commented Sep 28, 2017

r=me
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2017

💔 Test failed - linux-rel-css
@glennw glennw force-pushed the glennw:update-wr-memory branch from 02d096e to fb61c9f Sep 29, 2017
@glennw
Copy link
Member Author

glennw commented Sep 29, 2017

There is one test failure here. A change in the latest update to reduce the size of allocated render targets exposes an unrelated issue regarding snapping of composite / blend primitives. I opened a WR issue for this servo/webrender#1776 and marked the test as failing, for now.

r? @jdm with that change?
@highfive highfive assigned jdm and unassigned emilio Sep 29, 2017
@emilio
Copy link
Member

emilio commented Sep 29, 2017

Looks reasonable, as long as the intention is to fix it :)

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 29, 2017

📌 Commit fb61c9f has been approved by emilio
@highfive highfive assigned emilio and unassigned jdm Sep 29, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 29, 2017

⌛ Testing commit fb61c9f with merge b70c42a...
bors-servo added a commit that referenced this pull request Sep 29, 2017
@bors-servo
Auto merge of #18669 - glennw:update-wr-memory, r=emilio
Loading status checks…
b70c42a 
Update WR (reduce GPU allocations for render targets)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18669)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 29, 2017

💔 Test failed - mac-rel-css2
@gw3583
Update WR (rounded rect clip fixes).
Loading status checks…
eaf7c72
@glennw glennw force-pushed the glennw:update-wr-memory branch from fb61c9f to eaf7c72 Oct 2, 2017
@glennw
Copy link
Member Author

glennw commented Oct 2, 2017

We reverted the change in WR causing that test failure, for other reasons. So this is a normal WR update now, with various fixes for clips.

@bors-servo r=jdm,emilio
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2017

📌 Commit eaf7c72 has been approved by jdm,emilio
@highfive highfive assigned jdm and unassigned emilio Oct 2, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit eaf7c72 with merge eaedd43...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18669 - glennw:update-wr-memory, r=jdm,emilio
Loading status checks…
eaedd43 
Update WR (reduce GPU allocations for render targets)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18669)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - mac-rel-css2
@jdm
Copy link
Member

jdm commented Oct 3, 2017 

  ▶ CRASH [expected PASS] /css21_dev/html4/inline-formatting-context-015.htm

  ▶ CRASH [expected PASS] /css21_dev/html4/inline-formatting-context-013.htm

  ▶ CRASH [expected PASS] /css21_dev/html4/inline-formatting-context-011.htm
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 17.2.0-devel
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ CRASH [expected PASS] /css21_dev/html4/inline-formatting-context-022.htm
@glennw
Copy link
Member Author

glennw commented Oct 3, 2017

@bors-servo retry

  • I can't reproduce this locally, and the logs have no backtraces that I can see. Let's see if it's intermittent.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit eaf7c72 with merge 82cc22f...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18669 - glennw:update-wr-memory, r=jdm,emilio
Loading status checks…
82cc22f 
Update WR (reduce GPU allocations for render targets)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18669)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm,emilio
Pushing 82cc22f to master...
@bors-servo bors-servo merged commit eaf7c72 into servo:master Oct 3, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @bors-servo @jdm @emilio @highfive @gw3583
You can’t perform that action at this time.