Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: multiple cleanups. #18692

Merged
merged 5 commits into from Oct 1, 2017
Merged

style: multiple cleanups. #18692

merged 5 commits into from Oct 1, 2017

Conversation

@emilio
Copy link
Member

emilio commented Oct 1, 2017 •
edited by SimonSapin

This change is Reviewable
emilio added 5 commits Oct 1, 2017
@emilio
style: Avoid being so Arc-happy in the custom properties code.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
2adfd84
@emilio
style: deduplicate some code in the ComputedValues code.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
4933a54
@emilio
style: Remove boilerplate code in the properties module.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
d2dab24
@emilio
style: Rename get_visited_style to just visited_style.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
ab8dcf0
@emilio
style: Remove unused ComputedValues::has_visited_style.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
9305fad
@highfive
Copy link

highfive commented Oct 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, ports/geckolib/glue.rs, components/style/custom_properties.rs, components/style/style_resolver.rs, components/style/properties/declaration_block.rs and 6 more
  • @canaltinova: components/style/properties/gecko.mako.rs, components/style/custom_properties.rs, components/style/style_resolver.rs, components/style/properties/declaration_block.rs, components/style/properties/helpers/animated_properties.mako.rs and 5 more
@highfive
Copy link

highfive commented Oct 1, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Oct 1, 2017

r? @nox or @SimonSapin (or anyone else really)
@highfive highfive assigned nox and unassigned jdm Oct 1, 2017
@nox
Copy link
Member

nox commented Oct 1, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2017

📌 Commit 9305fad has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2017

⌛ Testing commit 9305fad with merge 7041fa1...
bors-servo added a commit that referenced this pull request Oct 1, 2017
@bors-servo
Auto merge of #18692 - emilio:cleanups, r=nox
Loading status checks…
7041fa1 
style: multiple cleanups.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18692)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2017

💔 Test failed - linux-rel-wpt
@emilio
Copy link
Member Author

emilio commented Oct 1, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2017

⌛ Testing commit 9305fad with merge 4d95e2c...
bors-servo added a commit that referenced this pull request Oct 1, 2017
@bors-servo
Auto merge of #18692 - emilio:cleanups, r=nox
Loading status checks…
4d95e2c 
style: multiple cleanups.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18692)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 4d95e2c to master...
@bors-servo bors-servo merged commit 9305fad into servo:master Oct 1, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 1, 2017
Merged
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @nox @bors-servo @jdm
You can’t perform that action at this time.