Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not force resource_path on android #18702

Merged
merged 1 commit into from Oct 4, 2017
Merged

do not force resource_path on android #18702

merged 1 commit into from Oct 4, 2017

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Oct 2, 2017 •
edited by SimonSapin

I want to be able to configure the resource path via set_resources_path.

This change is Reviewable
@paulrouget
do not force resource_path on android
Loading status checks…
aaab56c
@highfive
Copy link

highfive commented Oct 2, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@Manishearth
Copy link
Member

Manishearth commented Oct 2, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2017

📌 Commit aaab56c has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit aaab56c with merge fdfcb77...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18702 - paulrouget:android_res_path, r=Manishearth
Loading status checks…
fdfcb77 
do not force resource_path on android

I want to be able to configure the resource path via `set_resources_path`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Oct 3, 2017 •
edited

@bors-servo: retry
@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 3, 2017

@bors-servo: retry

#18715 #18723
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit aaab56c with merge 543ed2b...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18702 - paulrouget:android_res_path, r=Manishearth
Loading status checks…
543ed2b 
do not force resource_path on android

I want to be able to configure the resource path via `set_resources_path`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18702)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Oct 3, 2017
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit aaab56c with merge 3782f6c5893971ac7e962bea76661fadc9ded393...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - windows-msvc-dev
@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 3, 2017 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit aaab56c with merge 292cb08599061475fa73a5de27c5b1e597356cf7...
@highfive highfive removed the S-tests-failed label Oct 3, 2017
bors-servo added a commit that referenced this pull request Oct 4, 2017
@bors-servo
Auto merge of #18702 - paulrouget:android_res_path, r=Manishearth
Loading status checks…
4bc5aa7 
do not force resource_path on android

I want to be able to configure the resource path via `set_resources_path`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev
@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 4, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit aaab56c with merge c994d3f...
bors-servo added a commit that referenced this pull request Oct 4, 2017
@bors-servo
Auto merge of #18702 - paulrouget:android_res_path, r=Manishearth
Loading status checks…
c994d3f 
do not force resource_path on android

I want to be able to configure the resource path via `set_resources_path`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev
@jdm
Copy link
Member

jdm commented Oct 4, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit aaab56c with merge d4755e5...
bors-servo added a commit that referenced this pull request Oct 4, 2017
@bors-servo
Auto merge of #18702 - paulrouget:android_res_path, r=Manishearth
Loading status checks…
d4755e5 
do not force resource_path on android

I want to be able to configure the resource path via `set_resources_path`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Oct 4, 2017

@bors-servo: retry

  • missing ccache??
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit aaab56c with merge b1c2d71...
bors-servo added a commit that referenced this pull request Oct 4, 2017
@bors-servo
Auto merge of #18702 - paulrouget:android_res_path, r=Manishearth
Loading status checks…
b1c2d71 
do not force resource_path on android

I want to be able to configure the resource path via `set_resources_path`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing b1c2d71 to master...
@bors-servo bors-servo merged commit aaab56c into servo:master Oct 4, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@paulrouget @highfive @Manishearth @bors-servo @jdm @KiChjang
You can’t perform that action at this time.