Switch to using WebRender hit testing #18704

mrobinson · 2017-10-02T10:32:16Z

This trades quite a bit of complicated code in Servo for few more
messages and a significant performance improvement. In particular,
WebRender can search the entire display list at once instead of
ping-ponging down the pipeline tree. This allows us to send mouse
events to the correct pipeline immediately.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #__ (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because they should not change behavior.

This change is

highfive · 2017-10-02T10:32:20Z

Heads up! This PR modifies the following files:

@jgraham: tests/wpt/grouping_formatter.py
@emilio: components/layout/webrender_helpers.rs, components/layout/query.rs
@fitzgen: components/script/dom/document.rs, components/script/dom/window.rs, components/script/script_thread.rs, components/script_layout_interface/message.rs, components/script_traits/lib.rs and 2 more
@KiChjang: components/script/dom/document.rs, components/script/dom/window.rs, components/script/script_thread.rs, components/script_layout_interface/message.rs, components/script_traits/lib.rs and 2 more
@asajeffrey: components/constellation/constellation.rs
@paulrouget: components/compositing/compositor.rs, components/constellation/constellation.rs, components/compositing/compositor_thread.rs

highfive · 2017-10-02T10:32:21Z

Warning

These commits modify unsafe code. Please review it carefully!

mrobinson · 2017-10-02T10:32:29Z

@bors-servo try

bors-servo · 2017-10-02T10:32:33Z

⌛ Trying commit 52d356e with merge 64a4ea8...


        Auto merge of #18704 - mrobinson:wr-hit-testing, r=<try>

Switch to using WebRender hit testing This trades quite a bit of complicated code in Servo for few more messages and a significant performance improvement. In particular, WebRender can search the entire display list at once instead of ping-ponging down the pipeline tree. This allows us to send mouse events to the correct pipeline immediately.  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior.

mrobinson · 2017-10-02T10:37:45Z

This PR isn't quite ready to review, as I need to update the code style.

bors-servo · 2017-10-02T10:49:46Z

💔 Test failed - linux-dev

mrobinson · 2017-10-02T11:11:28Z

@bors-servo try

bors-servo · 2017-10-02T11:11:32Z

⌛ Trying commit 227be2a with merge e603814...


        Auto merge of #18704 - mrobinson:wr-hit-testing, r=<try>

Switch to using WebRender hit testing This trades quite a bit of complicated code in Servo for few more messages and a significant performance improvement. In particular, WebRender can search the entire display list at once instead of ping-ponging down the pipeline tree. This allows us to send mouse events to the correct pipeline immediately.  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18704)

bors-servo · 2017-10-02T12:14:23Z

💔 Test failed - mac-rel-wpt4

jdm · 2017-10-02T12:54:13Z

  ▶ Unexpected subtest result in /_mozilla/mozilla/scrollBy.html:
  │ FAIL [expected PASS] Ensure that the window.scrollBy function affects scroll position as expected
  │   → assert_equals: expected Element node <body>
    <a id="link" href="http://mozilla.org">This is... but got Element node <a id="link" href="http://mozilla.org">This is some link ...
  │ 
  │ @http://web-platform.test:8000/_mozilla/mozilla/scrollBy.html:23:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  │ test@http://web-platform.test:8000/resources/testharness.js:497:9
  └ @http://web-platform.test:8000/_mozilla/mozilla/scrollBy.html:10:5

mrobinson · 2017-10-02T15:23:06Z

@bors-servo try

bors-servo · 2017-10-02T15:23:11Z

⌛ Trying commit 83a9603 with merge 33f85dd8d8ce4b499eb9fd28bd10b9422e018c33...

bors-servo · 2017-10-02T16:19:20Z

💔 Test failed - linux-rel-css

mrobinson · 2017-10-02T16:32:31Z

  ▶ CRASH [expected OK] /css-transitions-1_dev/html/before-DOMContentLoaded-001.htm
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 17.2.0-devel
  │ called `Option::unwrap()` on a `None` value (thread LayoutThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(NonZero(1)) }, at /checkout/src/libcore/option.rs:335)
  │ stack backtrace:
  │    0:     0x7fb5a595605c - backtrace::backtrace::trace::hc558941d466d8278
  │    1:     0x7fb5a5956092 - backtrace::capture::Backtrace::new::ha6795f2bcb9f5158
  │    2:     0x7fb5a40533b5 - servo::main::{{closure}}::h525ba2edc1f14706
  │    3:     0x7fb5a63e0596 - std::panicking::rust_panic_with_hook
  │                         at /checkout/src/libstd/panicking.rs:578
  │    4:     0x7fb5a63e03b4 - std::panicking::begin_panic<alloc::string::String>
  │                         at /checkout/src/libstd/panicking.rs:538
  │    5:     0x7fb5a63e0329 - std::panicking::begin_panic_fmt
  │                         at /checkout/src/libstd/panicking.rs:522
  │    6:     0x7fb5a63e02ba - std::panicking::rust_begin_panic
  │                         at /checkout/src/libstd/panicking.rs:498
  │    7:     0x7fb5a641a680 - core::panicking::panic_fmt
  │                         at /checkout/src/libcore/panicking.rs:71
  │    8:     0x7fb5a641a5b6 - core::panicking::panic
  │                         at /checkout/src/libcore/panicking.rs:51
  │    9:     0x7fb5a42c5617 - layout_thread::LayoutThread::perform_post_style_recalc_layout_passes::hf58c3db4beedaa2e
  │   10:     0x7fb5a42c2d3d - layout_thread::LayoutThread::tick_all_animations::h27d058b230c3b980
  │   11:     0x7fb5a42b00ad - layout_thread::LayoutThread::handle_request_helper::h25bf1197f760cbdf
  │   12:     0x7fb5a42ab834 - <layout_thread::LayoutThread as layout_traits::LayoutThreadFactory>::create::{{closure}}::hee39b95ba0800712
  │   13:     0x7fb5a420b8c5 - std::sys_common::backtrace::__rust_begin_short_backtrace::h6656dd04e3083ef0
  │   14:     0x7fb5a42144a5 - std::panicking::try::do_call::hf425695f73c12133
  │   15:     0x7fb5a63e772c - panic_unwind::__rust_maybe_catch_panic
  │                         at /checkout/src/libpanic_unwind/lib.rs:99
  │   16:     0x7fb5a423eaf2 - <F as alloc::boxed::FnBox<A>>::call_box::h165d5e26aa343cdd
  │   17:     0x7fb5a63df21b - alloc::boxed::{{impl}}::call_once<(),()>
  │                         at /checkout/src/liballoc/boxed.rs:738
  │                          - std::sys_common::thread::start_thread
  │                         at /checkout/src/libstd/sys_common/thread.rs:24
  │                          - std::sys::imp::thread::{{impl}}::new::thread_start
  │                         at /checkout/src/libstd/sys/unix/thread.rs:90
  │   18:     0x7fb5a1d0c183 - start_thread
  │   19:     0x7fb5a1822ffc - clone
  │   20:                0x0 - <unknown>
  │ ERROR:servo: called `Option::unwrap()` on a `None` value
  └ Pipeline failed in hard-fail mode.  Crashing!

jdm · 2017-10-02T17:09:52Z

That's the same panic and backtrace that was observed in #18701.

mrobinson · 2017-10-03T07:12:37Z

Going to retry this in case it is an intermittent.

jdm · 2017-10-03T07:20:38Z

@bors-servo retry

bors-servo · 2017-10-03T07:24:02Z

⌛ Trying commit 83a9603 with merge 07a45689bfc1128b7c884ccef2fa78067919cb78...

bors-servo · 2017-10-17T19:45:08Z

⌛ Testing commit 7692145 with merge a12ba64...


        Auto merge of #18704 - mrobinson:wr-hit-testing, r=jdm,glennw,mbrubeck

Switch to using WebRender hit testing This trades quite a bit of complicated code in Servo for few more messages and a significant performance improvement. In particular, WebRender can search the entire display list at once instead of ping-ponging down the pipeline tree. This allows us to send mouse events to the correct pipeline immediately.  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18704)

bors-servo · 2017-10-17T19:50:36Z

💔 Test failed - linux-rel-css

jdm · 2017-10-17T20:35:36Z

error[E0433]: failed to resolve. Use of undeclared type or module `NonZeroU32`
   --> /home/servo/buildbot/slave/linux-rel-css/build/components/msg/constellation_msg.rs:255:38
    |
255 |                 index: PipelineIndex(NonZeroU32::new_unchecked(index)),
    |                                      ^^^^^^^^^^ Use of undeclared type or module `NonZeroU32`

jdm · 2017-10-17T20:35:50Z

I think you can use NonZero::new_unchecked now instead.


        Switch to using WebRender hit testing

This trades quite a bit of complicated code in Servo for few more messages and a significant performance improvement. In particular, WebRender can search the entire display list at once instead of ping-ponging down the pipeline tree. This allows us to send mouse events to the correct pipeline immediately.

mrobinson · 2017-10-17T21:33:49Z

Rebased and ready to go.

@bors-servo: r=jdm,glennw,mbrubeck

bors-servo · 2017-10-17T21:33:49Z

📌 Commit b5d51dd has been approved by jdm,glennw,mbrubeck

bors-servo · 2017-10-17T22:09:27Z

⌛ Testing commit b5d51dd with merge ca08271...


        Auto merge of #18704 - mrobinson:wr-hit-testing, r=jdm,glennw,mbrubeck

Switch to using WebRender hit testing This trades quite a bit of complicated code in Servo for few more messages and a significant performance improvement. In particular, WebRender can search the entire display list at once instead of ping-ponging down the pipeline tree. This allows us to send mouse events to the correct pipeline immediately.  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18704)

bors-servo · 2017-10-17T23:23:06Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm,glennw,mbrubeck
Pushing ca08271 to master...

mrobinson · 2017-10-18T06:16:19Z

Thanks for the reviews!

jrmuizel · 2017-10-18T15:06:12Z

@mrobinson How does this handle hit testing transparent backgrounds?

mrobinson · 2017-10-18T15:11:45Z

@jrmuizel Transparent backgrounds are handled by sending transparent rectangles with the display lit. They are added to the list of hit testing items, but are culled early from rendering.

highfive assigned metajack Oct 2, 2017

highfive added the S-awaiting-review label Oct 2, 2017

highfive added the S-tests-failed label Oct 2, 2017

mrobinson force-pushed the mrobinson:wr-hit-testing branch from 52d356e to 227be2a Oct 2, 2017

highfive removed the S-tests-failed label Oct 2, 2017

highfive added the S-tests-failed label Oct 2, 2017

mrobinson force-pushed the mrobinson:wr-hit-testing branch from 227be2a to 83a9603 Oct 2, 2017

highfive removed the S-tests-failed label Oct 2, 2017

highfive added the S-tests-failed label Oct 2, 2017

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Oct 17, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 17, 2017

mrobinson force-pushed the mrobinson:wr-hit-testing branch from 7692145 to b5d51dd Oct 17, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Oct 17, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 17, 2017

bors-servo merged commit b5d51dd into servo:master Oct 17, 2017
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Oct 17, 2017

This was referenced Oct 17, 2017

[WIP] Ensure every inline flow starts and ends with a text fragment. #18780

Open

Bug 1409255 - Replace all uses of the heapsize crate with malloc_size_of #18920

Closed

mrobinson deleted the mrobinson:wr-hit-testing branch Oct 18, 2017

mrobinson mentioned this pull request Jan 17, 2018

ScriptToCompositorMsg::ScrollFragmentPoint should take into account layers and transforms #8275

Closed

servo / servo

Switch to using WebRender hit testing #18704

Switch to using WebRender hit testing #18704

mrobinson commented Oct 2, 2017 •

edited by SimonSapin

highfive commented Oct 2, 2017

highfive commented Oct 2, 2017

mrobinson commented Oct 2, 2017

bors-servo commented Oct 2, 2017

mrobinson commented Oct 2, 2017

bors-servo commented Oct 2, 2017

mrobinson commented Oct 2, 2017

bors-servo commented Oct 2, 2017

bors-servo commented Oct 2, 2017

jdm commented Oct 2, 2017

mrobinson commented Oct 2, 2017

bors-servo commented Oct 2, 2017

bors-servo commented Oct 2, 2017

mrobinson commented Oct 2, 2017

jdm commented Oct 2, 2017

mrobinson commented Oct 3, 2017

jdm commented Oct 3, 2017

bors-servo commented Oct 3, 2017

bors-servo commented Oct 17, 2017

bors-servo commented Oct 17, 2017

jdm commented Oct 17, 2017

jdm commented Oct 17, 2017

mrobinson commented Oct 17, 2017

bors-servo commented Oct 17, 2017

bors-servo commented Oct 17, 2017

bors-servo commented Oct 17, 2017

mrobinson commented Oct 18, 2017

jrmuizel commented Oct 18, 2017

mrobinson commented Oct 18, 2017

servo / servo

Join GitHub today

Switch to using WebRender hit testing #18704

Switch to using WebRender hit testing #18704

Conversation

mrobinson commented Oct 2, 2017 • edited by SimonSapin

highfive commented Oct 2, 2017

highfive commented Oct 2, 2017

mrobinson commented Oct 2, 2017

bors-servo commented Oct 2, 2017

mrobinson commented Oct 2, 2017

bors-servo commented Oct 2, 2017

mrobinson commented Oct 2, 2017

bors-servo commented Oct 2, 2017

bors-servo commented Oct 2, 2017

jdm commented Oct 2, 2017

mrobinson commented Oct 2, 2017

bors-servo commented Oct 2, 2017

bors-servo commented Oct 2, 2017

mrobinson commented Oct 2, 2017

jdm commented Oct 2, 2017

mrobinson commented Oct 3, 2017

jdm commented Oct 3, 2017

bors-servo commented Oct 3, 2017

bors-servo commented Oct 17, 2017

bors-servo commented Oct 17, 2017

jdm commented Oct 17, 2017

jdm commented Oct 17, 2017

mrobinson commented Oct 17, 2017

bors-servo commented Oct 17, 2017

bors-servo commented Oct 17, 2017

bors-servo commented Oct 17, 2017

mrobinson commented Oct 18, 2017

jrmuizel commented Oct 18, 2017

mrobinson commented Oct 18, 2017

mrobinson commented Oct 2, 2017 •

edited by SimonSapin