Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: use FnvHashMap everywhere, remove default HashMap construction methods #18712

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
7 participants
@Manishearth
Copy link
Member

commented Oct 2, 2017

r=bholley bug 1385971


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Oct 2, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/position.mako.rs, components/style/rule_tree/mod.rs, components/style/dom.rs, components/style/gecko/wrapper.rs
  • @canaltinova: components/style/properties/longhand/position.mako.rs, components/style/rule_tree/mod.rs, components/style/dom.rs, components/style/gecko/wrapper.rs
  • @emilio: components/style/properties/longhand/position.mako.rs, components/style/rule_tree/mod.rs, components/style/dom.rs, components/style/gecko/wrapper.rs
@highfive

This comment has been minimized.

Copy link

commented Oct 2, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2017

@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2017

📌 Commit 335f3c0 has been approved by bholley

@highfive highfive assigned bholley and unassigned cbrewster Oct 2, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2017

⌛️ Testing commit 335f3c0 with merge 56d690d...

bors-servo added a commit that referenced this pull request Oct 2, 2017

Auto merge of #18712 - Manishearth:fnv, r=bholley
stylo: use FnvHashMap everywhere, remove default HashMap construction methods

r=bholley bug 1385971
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2017

💔 Test failed - linux-rel-wpt

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2017

@bors-servo retry

@bholley

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

💥 Test timed out

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2017

@bors-servo retry

@jdm jdm closed this Oct 3, 2017

@jdm jdm reopened this Oct 3, 2017

@mbrubeck

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

@bors-servo clean r-

@mbrubeck

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

📌 Commit 335f3c0 has been approved by mbrubeck

@highfive highfive assigned mbrubeck and unassigned bholley Oct 3, 2017

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2017

@bors-servo r=bholley clean retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

📌 Commit 335f3c0 has been approved by bholley

@highfive highfive assigned bholley and unassigned mbrubeck Oct 3, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

🔒 Merge conflict

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

☔️ The latest upstream changes (presumably #18732) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth Manishearth force-pushed the Manishearth:fnv branch from 335f3c0 to 8bce37e Oct 3, 2017

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2017

@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

📌 Commit 8bce37e has been approved by bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

⌛️ Testing commit 8bce37e with merge e96b023...

bors-servo added a commit that referenced this pull request Oct 3, 2017

Auto merge of #18712 - Manishearth:fnv, r=bholley
stylo: use FnvHashMap everywhere, remove default HashMap construction methods

r=bholley bug 1385971

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18712)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

💔 Test failed - windows-msvc-dev

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

⌛️ Testing commit 8bce37e with merge 89724c6...

bors-servo added a commit that referenced this pull request Oct 3, 2017

Auto merge of #18712 - Manishearth:fnv, r=bholley
stylo: use FnvHashMap everywhere, remove default HashMap construction methods

r=bholley bug 1385971

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18712)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2017

@bors-servo bors-servo merged commit 8bce37e into servo:master Oct 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@Manishearth Manishearth deleted the Manishearth:fnv branch Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.