Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse sizes attribute values #18714

Merged
merged 1 commit into from Oct 3, 2017
Merged

Parse sizes attribute values #18714

merged 1 commit into from Oct 3, 2017

Conversation

@jdm
Copy link
Member

jdm commented Oct 2, 2017 •
edited by SimonSapin

Squashed version of #17808.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix (partially) #11416
  • There are tests for these changes

This change is Reviewable
@Rakhisharma @jdm
Parse sizes attribute values.
Loading status checks…
c31b0e4
@highfive
Copy link

highfive commented Oct 2, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/servo/media_queries.rs
  • @canaltinova: components/style/servo/media_queries.rs
  • @KiChjang: components/script/test.rs, components/script/dom/htmlimageelement.rs
  • @fitzgen: components/script/test.rs, components/script/dom/htmlimageelement.rs
  • @emilio: components/style/servo/media_queries.rs
@jdm
Copy link
Member Author

jdm commented Oct 2, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2017

📌 Commit c31b0e4 has been approved by jdm
@highfive highfive assigned jdm and unassigned glennw Oct 2, 2017
@jdm jdm mentioned this pull request Oct 2, 2017
Closed
4 of 5 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit c31b0e4 with merge 77afc3f...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18714 - jdm:sizes, r=jdm
Loading status checks…
77afc3f 
Parse sizes attribute values

Squashed version of #17808.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #11416
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18714)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 77afc3f to master...
@bors-servo bors-servo merged commit c31b0e4 into servo:master Oct 3, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 3, 2017
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @bors-servo @glennw @Rakhisharma
You can’t perform that action at this time.