Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse srcset attribute values #18716

Merged
merged 1 commit into from Oct 4, 2017
Merged

Parse srcset attribute values #18716

merged 1 commit into from Oct 4, 2017

Conversation

@jdm
Copy link
Member

jdm commented Oct 2, 2017 •
edited by SimonSapin

Squashed version of #18313.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix (partially) #11416
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Oct 2, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/str.rs
  • @canaltinova: components/style/str.rs
  • @KiChjang: components/script/test.rs, components/script/dom/htmlimageelement.rs
  • @fitzgen: components/script/test.rs, components/script/dom/htmlimageelement.rs
  • @emilio: components/style/str.rs
@jdm
Copy link
Member Author

jdm commented Oct 2, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2017

📌 Commit c1026e2 has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Oct 2, 2017
@jdm jdm mentioned this pull request Oct 2, 2017
Closed
4 of 5 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

☔ The latest upstream changes (presumably #18714) made this pull request unmergeable. Please resolve the merge conflicts.
@iamneha @jdm
Parse srcset attribute
Loading status checks…
1f1ca3a
@jdm jdm force-pushed the jdm:parseSrcset branch from c1026e2 to 1f1ca3a Oct 3, 2017
@jdm
Copy link
Member Author

jdm commented Oct 3, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

📌 Commit 1f1ca3a has been approved by jdm
@jdm jdm added S-needs-rebase and removed S-needs-rebase labels Oct 3, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit 1f1ca3a with merge 265bfba...
bors-servo added a commit that referenced this pull request Oct 3, 2017
@bors-servo
Auto merge of #18716 - jdm:parseSrcset, r=jdm
Loading status checks…
265bfba 
Parse srcset attribute values

Squashed version of #18313.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #11416
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18716)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - windows-msvc-dev
@KiChjang
Copy link
Member

KiChjang commented Oct 3, 2017

@bors-servo retry infra
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit 1f1ca3a with merge b41b2bbd027eb604dbf4be363e227c7d7e2e8584...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - windows-msvc-dev
@KiChjang
Copy link
Member

KiChjang commented Oct 3, 2017

@bors-servo retry infra
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit 1f1ca3a with merge e94e9cc095da77574ca5751f6f8d0e8a138cc9ad...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev
@KiChjang
Copy link
Member

KiChjang commented Oct 4, 2017

@bors-servo retry infra
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit 1f1ca3a with merge d5e4015914de634741303a0ccfdb24f51d4bcee3...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

💔 Test failed - windows-msvc-dev
@jdm
Copy link
Member Author

jdm commented Oct 4, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

⌛ Testing commit 1f1ca3a with merge 1f91825...
bors-servo added a commit that referenced this pull request Oct 4, 2017
@bors-servo
Auto merge of #18716 - jdm:parseSrcset, r=jdm
Loading status checks…
1f91825 
Parse srcset attribute values

Squashed version of #18313.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #11416
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18716)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 1f91825 to master...
@bors-servo bors-servo merged commit 1f1ca3a into servo:master Oct 4, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @highfive @bors-servo @KiChjang @Manishearth @iamneha
You can’t perform that action at this time.